fix: Make GenericSkeleton::GetEvents() non-const#468
Open
NEOatNHNG wants to merge 1 commit into
Open
Conversation
NEOatNHNG
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
castler
approved these changes
May 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
In order to Allocate() or Send() an event, the user needs a mutable GenericSkeletonEvent. Fixes #467
castler
force-pushed
the
NEOatNHNG/GenericSkeletons-GetEvents-mutable
branch
from
89b9149 to
03c3425
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
bemerybmw
requested changes
May 29, 2026
Contributor
bemerybmw
left a comment
bemerybmw
left a comment
There was a problem hiding this comment.
This Pr should now be redundant with the proper fix here: #475. If you disagree @NEOatNHNG, please let me know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to Allocate() or Send() an event, the user needs a mutable GenericSkeletonEvent.
Fixes #467