feat: provide raw deltaX/deltaY/deltaMode in the mousewheel event#1162
Open
takaebato wants to merge 1 commit into
Open
feat: provide raw deltaX/deltaY/deltaMode in the mousewheel event#1162takaebato wants to merge 1 commit into
takaebato wants to merge 1 commit into
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Exposes the raw
deltaX/deltaY/deltaModeof the nativeWheelEventonElementEvent(resolves the TODO insrc/core/event.ts).Motivation
The normalized
wheelDeltaignoresdeltaMode, so its scale differs among browsers and devices (e.g. Chrome reports pixels, Firefox reports lines).With the raw values, downstream consumers (e.g. ECharts
RoamController) can precisely tune scroll/zoom sensitivity per device, without castinge.eventtoWheelEvent.Design notes
undefinedon non-wheel events and on legacy browsers (hence optional in the type).zrDelta/wheelDeltaare untouched; fully backward compatible.Feedback wanted
WheelEventthey stayundefined(hence optional in the type). This differs from existing props likeoffsetX/which, which fall back to computed values when the native prop is missing. Let me know if a fallback is preferred."mousewheel"event. An alternative would be a new spec-aligned"wheel"event; I kept the change small in this PR.DOM_DELTA_*constants are not exported: consumers (e.g. ECharts) are expected to referenceWheelEvent.DOM_DELTA_*directly inside their event handlers. Let me know if zrender should provide them alongsidedeltaMode.