Repository navigation
feat(install): offer kindling demo after setup - #152
Merged
Merged
Conversation
After the Claude Code setup step, prompt to load sample memory with `kindling demo --reset` (default yes) so new users can try search and browse straight away. The prompt is skipped when no terminal is available (CI, headless) or when KINDLING_NO_DEMO=1, so piped installs never hang. Closing hints now mention `kindling browse`, and `kindling demo` when the sample was not loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements C1 (install.sh demo prompt) from module 08 (conversion surface).
setup_claude_code,install.shasksLoad sample memory to try search? [Y/n]; yes (the default, including a bare Enter) runskindling demo --reset, loading sample memory into~/.kindling/demo/kindling.db.--resetkeeps reinstalls idempotent and only touches the demo database.has_ttycheck skips the prompt entirely when/dev/ttycannot be opened (CI, headless,setsid), so a piped install never hangs. When piped in a terminal the prompt still reads from/dev/tty, matching the existing Claude Code prompt.KINDLING_NO_DEMO=1skips the prompt (documented in the script header andpackaging/README.md).kindling demowarns instead of aborting the install.kindling browse, pluskindling demowhen the sample was not loaded.Testing
sh -n,dash -n, andshellcheck install.sh: clean.target/debug/kindling, and setsHOMEto a scratch directory:setsid, no tty): no prompt, no demo DB created, hints includekindling demokindling search JWT --db <scratch>/.kindling/demo/kindling.dbreturns the pinned demo resultn: demo skipped;KINDLING_NO_DEMO=1: no prompt--resetreloads cleanly with no warningscargo fmt --all -- --checkand prettier onpackaging/README.md: clean.A real end-to-end install from a GitHub Release is not possible yet: no published release carries Rust binaries with
kindling demo(blocked on the v0.4.0 release, see ISS-003).🤖 Generated with Claude Code