Repository navigation
fix(release): keep checksum log out of captured sha - #160
Merged
Merged
Conversation
fetch_sha256 logged its sidecar URL to stdout, so the value captured by $(fetch_sha256 ...) included the log line. The URL's slashes then broke the sed substitution and the v0.4.0 homebrew-tap-pr job failed. Send the log line to stderr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/generate-homebrew-formula.sh:fetch_sha256printed its "Fetching checksum: " line to stdout, so$(fetch_sha256 ...)captured it along with the hash. The URL's slashes then broke thesed s/.../.../substitution (unknown option to 's'), failing the v0.4.0open homebrew-tap PRjob.Test
./scripts/generate-homebrew-formula.sh v0.4.0locally: the formula gets version 0.4.0 and the four correct checksums (diff reverted, not committed).The v0.4.0 tap PR is opened separately from a local run, since re-running the release job would use the tagged (unfixed) script.
🤖 Generated with Claude Code