style: use a generator inside max() in the sync script - #12
Merged
Conversation
Codacy flags the list comprehension as R1728 (consider-using-generator). Building the list only to take its max allocates for nothing, and the generator is equivalent here because active[0] is always present, so the argument is never empty. Keeps this copy byte-identical to the one in the other repos. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line follow-up so every copy of
sync_python_versions.pystays byte-identical across the org.Codacy (enabled on
sdepack) flags the list comprehension insidemax()asR1728consider-using-generator. Building a throwaway list only to take its maximum allocates for nothing, and the generator is equivalent here becauseactive[0]is always present, so the argument is never empty.Codacy only gates
sdepack, but the script is meant to be one canonical file, so this lands everywhere to prevent drift.Verified: pylint 0, pydocstyle 0, ruff lint and
format --check0 against the repo configs, behaviour unchanged.🤖 Generated with Claude Code