Add ReduceSum/Min/Max/Prod operator support

.github/workflows/check-docstrings.yml

@@ -208,6 +208,9 @@ jobs:
           const commentMarker = '<!-- docstring-check-comment -->';
           body = commentMarker + '\n' + body;
 
+          const updatedAt = new Date().toISOString();
+          body += `\n\n_Last updated: ${updatedAt}_`;
+
           // Find existing comment from this action
           const comments = await github.rest.issues.listComments({
             issue_number: context.issue.number,

.gitignore

@@ -56,6 +56,20 @@ tags
 poetry.lock
 *.code-workspace
 .env
+*.vim
+
+# Cmake files
+**/CMakeFiles
+**/cmake_install.cmake
+**/CMakeCache.txt
+**/compile_commands.json
+**/.cache
+**/build
+**/_deps
+finn_xsi/finn_xsi/unittests/*.cmake
+finn_xsi/finn_xsi/unittests/Makefile
+finn_xsi/finn_xsi/VERSION
+
 settings.yaml
 */.cache/*
 
@@ -100,6 +114,9 @@ MANIFEST
 /data/
 *.csv
 
+# Mock templated simulation config
+finn_xsi/finn_xsi/rtlsim_config.hpp
+
 # Google Drive key for dashboard
 /gdrive-key/
 
@@ -108,7 +125,7 @@ MANIFEST
 
 # downloaded dep repos
 /deps/
-/finn_deps/
+finn_deps/
 
 # local test directories for benchmarking infrastructure
 bench_input

.gitlab-ci.yml

@@ -30,10 +30,10 @@ variables:
     value: "1"
   SLURM_TIMEOUT:
     description: "Select SLURM timeout"
-    value: "1-0" # [days-hours]
+    value: "3-0" # [days-hours]
   SLURM_PARTITION:
     description: "Slurm partition (e.g., normal, largemem, fpga, gpu)"
-    value: "normal"
+    value: "fpga"
   SLURM_QOS:
     description: "Optional --exclusive or QoS option (include --qos, e.g., --qos express)"
     value: ""
@@ -157,7 +157,7 @@ FINN Test Suite 2022.2:
     paths:
       - deps
   variables:
-    SCHEDULER_PARAMETERS: "-A $PROJECT_ACCOUNT -p $SLURM_PARTITION -t $SLURM_TIMEOUT $SLURM_QOS --nodes 1 --ntasks 1 --cpus-per-task $CPU_CORES --exclusive"
+    SCHEDULER_PARAMETERS: "-A $PROJECT_ACCOUNT -p $SLURM_PARTITION -t $SLURM_TIMEOUT $SLURM_QOS --nodes 1 --ntasks 1 --exclusive"
     PYTEST_PARALLEL: "$CPU_CORES"
   extends: .setup_full_2022_2
   script:
@@ -169,7 +169,7 @@ FINN Test Suite 2022.2:
       source finn-plus-venv/bin/activate
       dvc config cache.dir $CI_DVC_CACHE_DIR
       dvc pull
-      finn test --variant $TEST_SUITE --dependency-path ./deps --build-path $FINN_BUILD_DIR --num-default-workers 1 --num-test-workers $PYTEST_PARALLEL
+      finn test --variant $TEST_SUITE --dependency-path ./deps --build-path $FINN_BUILD_DIR --num-test-workers $PYTEST_PARALLEL -n 1
   artifacts:
     name: "test_reports"
     when: always

ci/.gitlab-setup.yml

@@ -2,9 +2,10 @@
 
 .n2_setup_general:
   before_script:
-    - ml lang/Python/3.10.4-GCCcore-11.3.0
+    - ml lang/Python/3.11.5-GCCcore-13.2.0
+    - ml devel/Boost/1.83.0-GCC-13.2.0
     - ml tools/git-lfs/3.6.1
-    - ml tools/UnZip/6.0-GCCcore-11.3.0
+    - ml tools/UnZip/6.0-GCCcore-13.2.0
     - ml devel/ncurses/5.9
     - ulimit -s unlimited # Increase stack size limit
 

ci/cfg/live_fifosizing.yml

@@ -6,7 +6,8 @@
         "model_path": [models/bnn-pynq/cnv-w1a1_qonnx.onnx],
         "folding_config_file": [models/bnn-pynq/cnv-w1a1_folding_config.json],
         "specialize_layers_config_file": [models/bnn-pynq/cnv-w1a1_specialize_layers.json],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
@@ -16,7 +17,8 @@
         "model_path": [models/bnn-pynq/cnv-w1a2_qonnx.onnx],
         "folding_config_file": [models/bnn-pynq/cnv-w1a2_folding_config.json],
         "specialize_layers_config_file": [models/bnn-pynq/cnv-w1a2_specialize_layers.json],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
@@ -26,7 +28,8 @@
         "model_path": [models/bnn-pynq/cnv-w2a2_qonnx.onnx],
         "folding_config_file": [models/bnn-pynq/cnv-w2a2_folding_config.json],
         "specialize_layers_config_file": [models/bnn-pynq/cnv-w2a2_specialize_layers.json],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
@@ -36,7 +39,8 @@
         "model_path": [models/bnn-pynq/tfc-w1a1_qonnx.onnx],
         "folding_config_file": [models/bnn-pynq/tfc-w1a1_folding_config.json],
         "specialize_layers_config_file": [models/bnn-pynq/tfc-w1a1_specialize_layers.json],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
@@ -46,7 +50,8 @@
         "model_path": [models/bnn-pynq/tfc-w1a2_qonnx.onnx],
         "folding_config_file": [models/bnn-pynq/tfc-w1a2_folding_config.json],
         "specialize_layers_config_file": [models/bnn-pynq/tfc-w1a2_specialize_layers.json],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
@@ -56,55 +61,62 @@
         "model_path": [models/bnn-pynq/tfc-w2a2_qonnx.onnx],
         "folding_config_file": [models/bnn-pynq/tfc-w2a2_folding_config.json],
         "specialize_layers_config_file": [models/bnn-pynq/tfc-w2a2_specialize_layers.json],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
 
     # GTSRB (cnv-w1a1)
     {
         "dut": ["gtsrb"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
 
     # KWS (MLP)
     {
         "dut": ["kws"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
 
     # Cybersecurity (MLP)
     {
         "dut": ["cybsec"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
 
     # MobileNetV1 (ImageNet)
     {
         "dut": ["mobilenetv1"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
 
     # VGG-10 (1D CNN) (RadioML)
     {
         "dut": ["vgg10"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
 
     # ResNet-50 (ImageNet)
     {
         "dut": ["resnet50"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
@@ -115,7 +127,8 @@
         "model_path": [models/resnet18/resnet18_w3a3_cifar100.onnx],
         "folding_config_file": [models/resnet18/resnet18_folding_config.json],
         "specialize_layers_config_file": [models/resnet18/resnet18_specialize_layers.json],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "synth_clk_period_ns": [10],
     },
@@ -128,7 +141,8 @@
         "model_path": ["models/transformer/finn-transformers/benchmark/streamlined.onnx"],
         "verify_input_npy": ["models/transformer/finn-transformers/benchmark/inp.npy"],
         "verify_expected_output_npy": ["models/transformer/finn-transformers/benchmark/out.npy"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "target_fps": [1000],
     },
@@ -140,7 +154,8 @@
         "model_path": ["models/transformer/finn-transformers/language/streamlined.onnx"],
         "verify_input_npy": ["models/transformer/finn-transformers/language/inp.npy"],
         "verify_expected_output_npy": ["models/transformer/finn-transformers/language/out.npy"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "target_fps": [1000],
     },
@@ -152,7 +167,8 @@
         "model_path": ["models/transformer/finn-transformers/radioml/streamlined.onnx"],
         "verify_input_npy": ["models/transformer/finn-transformers/radioml/inp.npy"],
         "verify_expected_output_npy": ["models/transformer/finn-transformers/radioml/out.npy"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "target_fps": [1000],
     },
@@ -164,7 +180,8 @@
         "model_path": ["models/transformer/finn-transformers/vision/streamlined.onnx"],
         "verify_input_npy": ["models/transformer/finn-transformers/vision/inp.npy"],
         "verify_expected_output_npy": ["models/transformer/finn-transformers/vision/out.npy"],
-        "live_fifo_sizing": [True],
+        "auto_fifo_depths": [True],
+        "auto_fifo_strategy": ["live_fifo"],
         "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
         "target_fps": [1000],
     },
@@ -182,7 +199,8 @@
     #     "lb_num_layers": [1],
     #     "rb_num_layers": [4, 8, 16],
 
-    #     "live_fifo_sizing": [True],
+    #     "auto_fifo_depths": [True],
+    #     "auto_fifo_strategy": ["live_fifo"],
     #     "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
     #     "synth_clk_period_ns": [10],
     # },
@@ -198,7 +216,8 @@
     #     "lb_num_layers": [1],
     #     "rb_num_layers": [4, 8, 16],
 
-    #     "live_fifo_sizing": [True],
+    #     "auto_fifo_depths": [True],
+    #     "auto_fifo_strategy": ["live_fifo"],
     #     "generate_outputs": [["bitfile", "pynq_driver", "deployment_package"]],
     #     "synth_clk_period_ns": [10],
     # }

ci/collect/collect.py

@@ -1030,7 +1030,7 @@ def extract_model_name(self, metadata):
                     # wrap in list
                     configuration[key] = [metadata_bench["params"][key]]
                 # overwrite FIFO-related params
-                configuration["live_fifo_sizing"] = [False]
+                # configuration["live_fifo_sizing"] = [False]
                 configuration["auto_fifo_depths"] = [False]
                 configuration["target_fps"] = ["None"]
                 configuration["folding_config_file"] = [folding_config_lfs_path]