Share a file whose mime type is not one of the supported ones

[hayaksi1]

Content

DefaultShareIntentHandler.handleIncomingShareIntent only accepted an intent whose resolved mime
type started with image/, video/, audio/, application/, file/, text/ or */. An
ACTION_SEND carrying EXTRA_STREAM with any other top level type fell through to null, and
IntentResolver drops the intent, so nothing happened when sharing into the app.

The uris are already extracted before that check, so their presence is enough to know the intent
carries something to send. The mime type list is kept for the case where there are no uris, so no
currently accepted intent is affected.

Motivation and context

Fixes #5623. The reporter shares a .zip from Tasks, which sends it as message/rfc822. The
manifest filter for the share target is */*, so the app advertises that it accepts this and then
silently discards it.

Tests

• ./gradlew :features:share:impl:testDebugUnitTest
• New DefaultShareIntentHandlerTest covers an unlisted mime type with one uri, with several uris,
  with an EXTRA_TEXT caption, plus the image, plain text and nothing-to-share cases. The three
  unlisted-mime-type tests fail without the change.

Tested devices

• Physical
• Emulator
• OS version(s):

[github-actions]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
• Your branch should be based on origin/develop, at least when it was created.
• The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[bmarty]

OK, thanks!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.69%. Comparing base (23b75c3) to head (8e02f03).
⚠️ Report is 31 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7435      +/-   ##
===========================================
+ Coverage    80.65%   80.69%   +0.04%     
===========================================
  Files         2772     2772              
  Lines        80803    80804       +1     
  Branches     11053    11054       +1     
===========================================
+ Hits         65168    65203      +35     
+ Misses       11370    11336      -34     
  Partials      4265     4265              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hayaksi1]

Done!

Codecov flagged the patch at 50%: accepting the intent as soon as it carries uris short-circuits the mime type list, so type.isMimeTypeImage() was only ever evaluated to false. The new tests run one intent per listed mime type with no uri, which takes that line — and the whole when — to full branch coverage.

While the handler was under test I covered the paths that had none: an intent with no resolvable type, an ACTION_SEND_MULTIPLE with no stream, an action which is neither send nor send multiple, an empty caption, a plain text intent with no text, the mime type the content resolver reports for the uri, and the explicit intent built for the application which will read it, both when the read permission can be granted and when it cannot.

DefaultShareIntentHandler.kt is now at 45/45 lines and 49/50 branches with :features:share:impl:koverXmlReport. The remaining branch is the null check Kotlin generates for ?.toString() on line 54, which cannot be taken.