Stop waiting for a room alias that the remote server never resolves - #7446
Open
hayaksi1 wants to merge 1 commit into
Open
Stop waiting for a room alias that the remote server never resolves#7446hayaksi1 wants to merge 1 commit into
hayaksi1 wants to merge 1 commit into
Conversation
Tapping a room alias whose server is down left the resolver screen on a spinner for as long as the screen stayed open, with no way forward other than going back. Bound the resolution with the ten second timeout already used when joining a room by address, so the retry dialog is shown instead. The fake client's resolve lambda becomes suspending so a server that never answers can be simulated.
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7446 +/- ##
===========================================
- Coverage 80.65% 80.64% -0.02%
===========================================
Files 2772 2772
Lines 80803 80806 +3
Branches 11053 11054 +1
===========================================
- Hits 65168 65162 -6
- Misses 11370 11381 +11
+ Partials 4265 4263 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jmartinesp
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Tapping a room alias whose homeserver is unreachable left the resolver screen on a spinner for as long as the screen stayed open.
resolveRoomAliaswas awaited with no bound, so a federation request that never comes back never produced a state the screen could render, and the only way out was to press back.The resolution is now bounded by the same ten second timeout that resolving an address already uses when joining a room by address, and a timeout surfaces as a failure. The screen then shows its retry dialog rather than spinning.
The alias is still not resolved locally for a room the user has already joined, which is what the reporter suggested; that needs a way to look a room up by alias that the client does not expose today.
Motivation and context
Part of #5267.
Tests
features/roomaliasresolver/impl/.../RoomAliasHelperPresenterTest.kt: a client whose resolution never completes ends in a failure state instead of staying loading.FakeMatrixClient's resolve lambda becomes suspending so a server that never answers can be simulated; existing callers are unchanged.Tested devices
Checklist