Expose the timeline item long press and swipe to reply as TalkBack actions - #7458
Open
hayaksi1 wants to merge 1 commit into
Open
Expose the timeline item long press and swipe to reply as TalkBack actions#7458hayaksi1 wants to merge 1 commit into
hayaksi1 wants to merge 1 commit into
Conversation
Long pressing a timeline item opens the action list, and swiping it starts a reply. Neither gesture is reachable with a screen reader enabled, so those two actions were unavailable to TalkBack users. Publish them as accessibility custom actions on the event row, reusing the existing "Message actions" and "Reply" strings. The reply action is only offered when the user is allowed to reply, matching the swipe.
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
A timeline item carries two gesture-only actions: long press opens the message action list, and a horizontal swipe starts a reply. Neither is reachable with TalkBack enabled, so a screen reader user cannot reach the action list at all — this is what the issue reports.
Publish both as accessibility custom actions on the event row, reusing the existing "Message actions" and "Reply" strings so no new translations are needed. The reply action is only offered when the user is allowed to reply, matching the condition that enables the swipe.
The scope is deliberately limited to restoring actions that already exist for sighted users. The larger list discussed on the issue — react, edit, share, links, view profile — is a product decision about which actions deserve to be surfaced directly rather than through the action list, so it is left out.
Motivation and context
Part of #4600.
Tests
No new automated test: the module's timeline view tests assert on rendered content, and Robolectric does not run the accessibility delegate that turns
customActionsinto TalkBack actions, so a test here would only re-assert the semantics property I just set.Manual check: with TalkBack on, focus a message and open the local context menu — "Message actions" and "Reply" are listed, and each performs the same action as the gesture.
Tested devices
Checklist