Use the right base URL for the ESS config/well known endpoints - #7469
Open
jmartinesp wants to merge 4 commits into
Open
Use the right base URL for the ESS config/well known endpoints#7469jmartinesp wants to merge 4 commits into
jmartinesp wants to merge 4 commits into
Conversation
…ng base URL data (server name, homeserver URL)
Calculate the URL in `DefaultRemoteEnterpriseConfigRetriever` using the newly added `homserver` and `server` values as the possible base URLs, depending on the remote config source
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7469 +/- ##
========================================
Coverage 80.64% 80.64%
========================================
Files 2758 2759 +1
Lines 80588 80594 +6
Branches 11029 11028 -1
========================================
+ Hits 64989 64998 +9
+ Misses 11342 11340 -2
+ Partials 4257 4256 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ig when restoring a session Add a `needsRefresh` parameter to `RemoteEnterpriseConfigResult.NotFound` to handle this, and store a `no-config` value in the store to indicate an endpoint has been checked and no config was found
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Content
UrlContentFetchertoClientUrlContentFetcherand add a coupleserverandhomeserverUrlproperties to it, so anything using the fetcher can use any of those as base URLs. This is needed for a Pro feature.NotFound(needsRefresh = false)so we know we've already checked and there was nothing there. This should still trigger a request to fetch the value, but on background, not blocking. This was causing the session restoration to be slower than needed, sinceContentScannerUrlProviderwas trying to fetch the remote config.FOSS part of https://github.com/element-hq/element-android-enterprise/pull/45
Motivation and context
Tests
With Element Pro, check the right ESS config endpoint and alternatively the right well-known endpoints are checked.
Tested devices
Checklist