Fix some issues in the new timeline renderer by jmartinesp · Pull Request #7751 · element-hq/element-x-android

jmartinesp · 2026-09-23T07:12:04Z

Content

Fixes some reported issues about the new timeline renderer:

ParagraphView having a smaller size than the rest of the timeline contents.
Clicking or long pressing on ParagraphView not passing the events to the parent, so long pressing without a URL annotation below had no effect in the message bubble.
Mention pills now don't have vertical padding, they're smaller and should look like the old ones did.
Code blocks displaying fading edges even when they could not scroll.

Motivation and context

These issues were reported by @frebib .

Screenshots / GIFs

In the PR.

Tests

Enable the feature flag and check these work as expected, I guess?

Tested devices

Physical
Emulator
OS version(s):

Checklist

github-actions · 2026-09-23T07:31:18Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AMpguG

codecov · 2026-09-23T07:34:48Z

Codecov Report

❌ Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.09%. Comparing base (e5c078c) to head (a6dddcd).

Files with missing lines	Patch %	Lines
...ibraries/htmlrenderer/api/ui/HtmlMessageContent.kt	4.76%	19 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7751      +/-   ##
===========================================
- Coverage    81.11%   81.09%   -0.02%     
===========================================
  Files         2797     2797              
  Lines        82992    83006      +14     
  Branches     11437    11440       +3     
===========================================
  Hits         67316    67316              
- Misses       11273    11287      +14     
  Partials      4403     4403

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This should make them look like they did in the previous renderer

… url annotation is clicked or long clicked `detectTapGestures` always consumes the touch events, no matter if they are handled or not, blocking these events from reaching parent components. Should fix the issue of `ParagraphView` blocking the long press action in the message bubbles

frebib · 2026-09-23T14:50:50Z

The composer is all kinds of broken in the Added here. Race/timing issue?

In fact, quite a few of the screenshots are like this either before or after. Weird.

It's also happening in other PRs too https://github.com/element-hq/element-x-android/pull/7759/changes#diff-8213ffc39b625c193fa8d085a94513113d7d735cb284b88fe1f46037343dd626

This is a problem with recorded screenshots since the last version of paparazzi, which we can't downgrade. It's sadly expected.

ganfra · 2026-09-23T15:22:28Z


        // Previews and screenshots can't render the fading edge gradients properly, everything is obscured by them, so we skip them in the preview mode.
-        if (LocalInspectionMode.current.not()) {
+        if (LocalInspectionMode.current.not() && scrollState.maxValue > 0) {


Should we not use canScrollForward || canScrollBackward instead?

I could have sworn last time I tried to use that it didn't work. Maybe the problem was in the previews, but it does work well in an actual device. Will change it.

ganfra · 2026-09-23T15:26:13Z

-        },
-        onLongPress = { offset ->
-            val (url, urlText) = layoutResult.value?.urlAt(offset, text) ?: return@detectTapGestures
+    awaitEachGesture {


Why are we moving away from detectTapGestures? I'm not familiar enough with the api, but detectTapGesture is using a loop, here I think we'll mostly drop relevant events? Have you tried on a regular device, not emulator?

Why are we moving away from detectTapGestures?

Because detectTapGestures consumes the events and any touch events that should go to the message bubble are ignored.

detectTapGesture is using a loop, here I think we'll mostly drop relevant events?

I thought so too, but it's working fine. Since we just want to check down -> up, it seems to work. Maybe it won't if there is a move, but I think we might want to ignore those. I can double check.

Have you tried on a regular device, not emulator?

Yes, in fact I only tested it in my test device, I didn't even use the emulator.

ganfra · 2026-09-23T15:28:33Z

+                if (up.pressed) return@withTimeout null
+                up.consume()
+
+                up.uptimeMillis - down.uptimeMillis > longPressTimeout


It's probably deadcode because of the withTimeout(longPressTimeout)

Hmm, true. At first I wanted to trigger this just on the up event, but that led to some weird interactions, so I added the timeout, but having the exact same value as the check before it'll just ignore the up event.

…g edges in the code blocks

sonarqubecloud · 2026-09-24T10:59:33Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ganfra

Ok let's merge this and continue to iterate!

jmartinesp added the PR-Bugfix For bug fix label Sep 23, 2026

jmartinesp changed the title ~~Make ParagraphView follow LocalTextStyle.current~~ Fix some issues in new timeline renderer Sep 23, 2026

jmartinesp changed the title ~~Fix some issues in new timeline renderer~~ Fix some issues in the new timeline renderer Sep 23, 2026

jmartinesp marked this pull request as ready for review September 23, 2026 07:28

jmartinesp requested a review from a team as a code owner September 23, 2026 07:28

jmartinesp requested review from ganfra and removed request for a team September 23, 2026 07:28

jmartinesp added 3 commits September 23, 2026 15:18

Don't show fading edge if the code block can't scroll

fb8393c

Don't add extra vertical padding to the mention pills

bf48a41

This should make them look like they did in the previous renderer

jmartinesp force-pushed the fix/issues-with-new-timeline-renderer branch from 0be2b99 to bf5af4b Compare September 23, 2026 13:22

Update screenshots

389603e

frebib reviewed Sep 23, 2026

View reviewed changes

ganfra reviewed Sep 23, 2026

View reviewed changes

jmartinesp added 2 commits September 24, 2026 09:07

Use canScrollForward || canScrollBackwards for displaying the fadin…

287f964

…g edges in the code blocks

Make linkTapHandler more resilient

bc45ed8

jmartinesp added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. and removed Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Sep 24, 2026

Merge branch 'develop' into fix/issues-with-new-timeline-renderer

a6dddcd

jmartinesp requested a review from ganfra September 24, 2026 13:26

ganfra approved these changes Sep 25, 2026

View reviewed changes

jmartinesp merged commit 4bf2a09 into develop Sep 26, 2026
32 of 34 checks passed

jmartinesp deleted the fix/issues-with-new-timeline-renderer branch September 26, 2026 11:02

Conversation

jmartinesp commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

github-actions Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmartinesp Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 24, 2026

Quality Gate passed

Uh oh!

ganfra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmartinesp commented Sep 23, 2026 •

edited

Loading

github-actions Bot commented Sep 23, 2026 •

edited

Loading

codecov Bot commented Sep 23, 2026 •

edited

Loading

jmartinesp Sep 24, 2026 •

edited

Loading