Skip to content

Add pillification to the new timeline renderer - #7761

Draft
jmartinesp wants to merge 9 commits into
developfrom
feat/add-pillification-to-the-new-timeline-renderer
Draft

jmartinesp wants to merge 9 commits into
developfrom
feat/add-pillification-to-the-new-timeline-renderer

Conversation

@jmartinesp

Copy link
Copy Markdown
Member

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

jmartinesp and others added 9 commits September 23, 2026 15:18
This should make them look like they did in the previous renderer
… url annotation is clicked or long clicked

`detectTapGestures` always consumes the touch events, no matter if they are handled or not, blocking these events from reaching parent components.

Should fix the issue of `ParagraphView` blocking the long press action in the message bubbles
Improve the regex matching too in `MatrixPatterns`
@jmartinesp jmartinesp added the PR-Feature For a new feature label Sep 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GEwGLD

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.07692% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (e5c078c) to head (6bdfdf8).
⚠️ Report is 31 commits behind head on develop.

Files with missing lines Patch % Lines
...ibraries/htmlrenderer/api/ui/HtmlMessageContent.kt 4.76% 19 Missing and 1 partial ⚠️
.../htmlrenderer/impl/AnnotatedStringPillification.kt 87.50% 0 Missing and 10 partials ⚠️
.../timeline/components/event/TimelineItemTextView.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7761      +/-   ##
===========================================
- Coverage    81.11%   81.10%   -0.01%     
===========================================
  Files         2797     2798       +1     
  Lines        82992    83108     +116     
  Branches     11437    11463      +26     
===========================================
+ Hits         67316    67405      +89     
- Misses       11273    11290      +17     
- Partials      4403     4413      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from fix/issues-with-new-timeline-renderer to develop September 26, 2026 11:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Feature For a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants