Skip to content

add: mcpmarket.com as registry source - #59

Open
dineshg0pal wants to merge 4 commits into
eljulians:masterfrom
dineshg0pal:add-mcpmarket
Open

dineshg0pal wants to merge 4 commits into
eljulians:masterfrom
dineshg0pal:add-mcpmarket

Conversation

@dineshg0pal

@dineshg0pal dineshg0pal commented Apr 1, 2026

Copy link
Copy Markdown

added mcpmarket.com as registry source

this pr adds support to mcpmarket.com as new registry in skill search

Changes:

  • added McpMarket registry
  • integrated into registry system with existing sources
  • updated enum, registry list & search handling

Notes:

  • minimal implementation (returns empty results now)
  • can be extended later to support full parsing

Fixes #51

@eljulians

Copy link
Copy Markdown
Owner

@dineshg0pal You can run cargo fmt to fix the formatting issues, sorry for the hassle

@dineshg0pal

dineshg0pal commented Apr 1, 2026

Copy link
Copy Markdown
Author

i done the cargo fmt and cargo build, but i didnt know what problem ?? does PR okay ? if any thing, pls mention

@eljulians

Copy link
Copy Markdown
Owner

clippy is failing, let me checkout the branch and fix them, if that's fine

@eljulians

Copy link
Copy Markdown
Owner

@dineshg0pal pushed this commit 707c9b2

@codecov

codecov Bot commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.14%. Comparing base (a95cb2c) to head (707c9b2).
⚠️ Report is 114 commits behind head on master.

Files with missing lines Patch % Lines
crates/sources/src/registry/mcpmarket.rs 37.50% 10 Missing ⚠️
crates/sources/src/registry/mod.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files          36       37       +1     
  Lines       15509    15531      +22     
==========================================
+ Hits        14137    14155      +18     
- Misses       1372     1376       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eljulians

Copy link
Copy Markdown
Owner

Thanks @dineshg0pal. I believe it would be beneficial to already implement the actual logic, since the current changes won't actually fix the issue

@dineshg0pal

Copy link
Copy Markdown
Author

Thanks! For the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mcpmarket.com to the skill search

2 participants