Repository navigation
Fix disabling the cursor - #2016
Merged
Merged
Fix disabling the cursor #2016
Conversation
real-or-random
referenced
this pull request
in doomemacs/core
Apr 27, 2026
monoid
reviewed
May 6, 2026
| @@ -732,9 +732,11 @@ filename." | |||
| SPECS may be a cursor type as per `cursor-type', a color | |||
| string as passed to `set-cursor-color', a zero-argument | |||
| function for changing the cursor, or a list of the above." | |||
Contributor
Author
There was a problem hiding this comment.
Happy to do that once some maintainer shows interest in this PR
Member
There was a problem hiding this comment.
Yep, update the docstring and I'll merge
Contributor
Author
There was a problem hiding this comment.
Okay, I force-pushed to make it clear that only non-empty lists are interpreted as lists. Let me know if you're happy with that change.
Without this, evil-set-cursor treats nil as an empty list of specs (i.e., a noop). But nil is a valid single spec; namely it's a valid value of the cursor-type variable, which means "don't show a cursor". This also inverts rewrites the logic to use (when (or ...)) instead of (unless (and ...)) because that's much more readable, at least to me. Fixes emacs-evil#592.
real-or-random
force-pushed
the
202604-nil-cursor-type
branch
from
June 2, 2026 06:47
006dc3e to
df13e78
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, evil-set-cursor treats nil as an empty list of specs (i.e., a noop). But nil is a valid single spec; namely it's a valid value of the cursor-type variable, which means "don't show a cursor".
This also inverts rewrites the logic to use (when (or ...)) instead of (unless (and ...)) because that's much more readable, at least to me.
Fixes #592.