Repository navigation
Split the functional test workflows by trust level - #278
Merged
Merged
Conversation
- functional.yml runs the emulator tests for every pull request, including pull requests from forks and Dependabot, because they don't use secrets. - functional-cloud.yml runs the cloud tests for pushes to main and for pull requests from this repository. A maintainer can run it for other pull requests after review, with the full SHA of the reviewed commit. The run stops before running pull request code if the head is a different commit. - Remove functional-emulators.yml and functional-manual.yml, which the two workflows above replace. - Run the dotnet.yml builds as one matrix job with the same check names.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…s after a failed check A run on a Dependabot branch that someone else starts, for example by pushing a commit, gets the repository secrets, so check the pull request author as well as the actor. A manual run that fails the reviewed-commit check no longer uploads files from the unreviewed commit.
GitHub runs the copy of the workflow on the branch the run uses, so a run from another branch might not check the reviewed commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emulator functional tests don't use any secrets, but they only ran automatically for pull requests from this repository. Forks and Dependabot needed a second workflow with the opposite condition. The cloud tests need the repository secrets, so they must run only for trusted code.
This splits the functional workflows by what they need instead of by who opened the pull request.
Changes
functional.ymlruns only the emulator tests, for pushes tomainand for every pull request, including forks and Dependabot. New pushes to a pull request cancel the older run, the same asdotnet.yml.functional-cloud.yml(new) runs the cloud tests for pushes tomainand for pull requests from this repository. The job is skipped for forks, which GitHub doesn't give the secrets to, and for pull requests that Dependabot opens. GitHub does give the secrets to a run on a Dependabot pull request when someone else starts it, for example by pushing a commit, so the job checks the pull request author as well as the actor.main:sleet-test-*containers and buckets behind in the test accounts.functional-emulators.ymlandfunctional-manual.yml, which these two workflows replace.dotnet.ymlruns the three builds as one matrix job. The check names (build-linux,build-mac,build-win) and artifact names are unchanged.CONTRIBUTING.md, the CI section oflocal-env/README.md,Sleet.slnx, and adds a cloud tests badge toREADME.md. The badge only counts push runs, so failed manual runs for pull requests don't affect it.Testing
build.ps1passes.functional.yml,functional-cloud.yml, and thedotnet.ymlmatrix, and they pass. The manual run can't be tested until the workflow is onmain, because GitHub only startsworkflow_dispatchruns for workflows on the default branch.