Repository navigation
Fix vulnerable Pkcs dependency blocking Dependabot updates - #284
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot PRs #281, #282, and #283 fail during restore because NuGet.Packaging 7.9.0 brings in System.Security.Cryptography.Pkcs 8.0.1, which triggers NU1902 and NU1903 for GHSA-2fmv-rv2c-59x7 and GHSA-846f-f764-76mx.
Add a centrally versioned direct reference to patched Pkcs 8.0.2 in SleetLib so all target frameworks and packaged consumers receive the fix. Keep vulnerability auditing and warnings-as-errors enabled, and document the update in the release notes.
Validation:
build.ps1passed (1,938 tests passed, 3 skipped). The solution-wide transitive package audit reports no vulnerable packages, and the generated SleetLib package declares Pkcs 8.0.2 for net8.0, net9.0, and net10.0.