INSDC Project compliance: enforce field constraints and add Collaborator affiliation support - #45
Open
mgonzalezporta wants to merge 1 commit into
Open
INSDC Project compliance: enforce field constraints and add Collaborator affiliation support#45mgonzalezporta wants to merge 1 commit into
mgonzalezporta wants to merge 1 commit into
Conversation
…scription length constraints, restructure Collaborator to support affiliation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@mgonzalezporta @haseeb-gh I would recommend adding a couple of unit tests for this change.
|
dipayan1985
requested changes
Apr 20, 2026
dipayan1985
left a comment
Contributor
There was a problem hiding this comment.
I would recommend adding unit tests for project serialization and deserialization and webin submission serialization and deserialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the Project entity in webin-xml with the INSDC minimum specifications.
Changes
minOccurs="0"), no length checkminOccurs="1", addedminLength=20/maxLength=4000restrictionminLength=20/maxLength=250restrictioncenter_nameattributeObjectTypexs:choiceCOLLABORATORwas a plain stringCOLLABORATORis now a complex type withNAME+AFFILIATIONchildren. NewCollaborator.javamodel.collaboratorsfield added toProject.javaandXmlProject.javawith mapping in both directions.COLLABORATORrestructure above —AFFILIATIONis an optional child elementPROJECT_LINKSFiles changed
ENA.project.xsd— Description mandatory + length constraints on Title/Description + Collaborator restructureProject.java— Addedcollaboratorsfield + mappingXmlProject.java— Addedcollaboratorsfield with XML annotations + mappingCollaborator.java— New model class (name + affiliation)Not addressed at schema level
These are application-level concerns that cannot be enforced via XSD:
Testing
Important: No tests have been run (no access to GitLab token)