DEVEX-1773: mute common-bump Slack alert until CI notification routing lands - #167
DEVEX-1773: mute common-bump Slack alert until CI notification routing lands#167pdodgen-revparts wants to merge 1 commit into
Conversation
The "Common could not be automatically updated" alert posts into #releases, where its volume is drowning the deploy notifications it sits alongside. DEVEX-1773 routes these to the owning team's channel via a CODEOWNERS lookup, but it's gated on provisioning the encodium-ci-notifier Slack app and its org secret, which isn't done yet. Adds a slack_alerts input, defaulting to false, and gates the Slack post step on it. Freeze detection is untouched: the step still writes the composer why-not diagnostic to the job summary, still emits ::error::, and still exits 1. Callers keep the signal through the red check and GH email/mobile - the same fallback the workflow already documents for callers that never passed a webhook. No caller changes required; repos passing slack_webhook_url keep passing it harmlessly. Restore by flipping the default, or opt in per-caller with slack_alerts: true. When DEVEX-1773 lands it replaces this step wholesale and the input should be removed rather than re-defaulted.
PR SummaryLow Risk Overview A new Silent-freeze detection is unchanged: the job still fails, writes the Reviewed by Cursor Bugbot for commit 15c226c. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Closing — wrong repo. Reopened against the right repo: encodium/actions#58 |
1 participant
Description
Mutes the
⚠️ Common could not be automatically updated on …Slack alert emitted byphp-common-bump.yaml's freeze-detection step.slack_alertsworkflow_call input,type: boolean, defaulting tofalseFreeze detection itself is untouched. The step still writes the
composer why-notdiagnostic to the job summary, still emits::error::, and stillexit 1. Only the Slack POST is suppressed. Callers keep the signal via the red check and GitHub email/mobile — the same fallback path the workflow already documents for callers that never passed a webhook in the first place.Jira Issue: https://revolutionparts.atlassian.net/browse/DEVEX-1773
Background
#releasesis doing double duty: high-signal deploy notifications alongside high-volume CI churn. The common-freeze alert (added in #161, wording updated in #163) is one of the three noisy sources DEVEX-1773 identifies, and right now it's drowning the deploy pings it sits next to.DEVEX-1773's actual fix routes these to the owning team's channel via a CODEOWNERS lookup and a
resolve-notify-channelcomposite action. That's blocked on two prereqs that aren't done: provisioning theencodium-ci-notifierSlack app withchat:write, and landing theSLACK_CI_NOTIFIER_TOKENorg secret. It's also sequenced behind DEVEX-1772.Rather than leave the channel noisy while those clear, this mutes the alert in the interim.
Why an input rather than deleting the step or hardcoding the condition:
secrets.slack_webhook_urlkeep passing it; it just becomes a no-op. Nothing downstream needs to change.true.slack_alerts: truewithout waiting on DEVEX-1773.chat.postMessage+ the composite). The input is explicitly documented as something to remove at that point, not re-default, so it doesn't calcify into a permanent knob.Scope note
DEVEX-1773 names three noisy sources. This PR covers only the common-bump alert — the one currently firing.
nightly-common-update.yamllives in each participating repo and needs a fleet sweep;notify-ci-failure.yamlis no longer in this repo. Both are left for DEVEX-1773 proper.Testing Information
Static verification only — this is a workflow-call gate with no in-repo caller to exercise, and triggering it for real would require a genuine peer-constraint block on a participating repo.
actionlinton the modified file reports 2SC2086findings;actionlintonmain's version of the same file reports the same 2, in the pre-existingCommit Common Bumprun block. No new findings introduced.YAML parses cleanly;
slack_alertsresolves to a real booleanfalse(not the string"false"), so&& inputs.slack_alertsshort-circuits correctly rather than being truthy.Diff excluding comments is 6 lines: the 5-line input definition and the one-line
if:change. Confirmed no change to the detection block'sexit 1,::error::, or job-summary writes.Resolved gate condition:
Verifying after merge
Next time a participating repo hits a real freeze, expect: red check,
::error::in the log, why-not diagnostic in the job summary, and no#releasespost.