⚡ fix N+1 query in settings screen level labels

[eng618]

💡 What: Replaced the sequential ref.read calls inside a for-loop with a concurrent implementation using Future.wait in _loadLabels of the settings screen.
🎯 Why: The previous implementation suffered from an N+1 query performance bottleneck, blocking UI or dialog rendering by fetching level data one-by-one.
📊 Measured Improvement: A simulated benchmark demonstrated a massive speed improvement. For fetching 50 levels (simulated 50ms per network delay), the sequential approach took 2549ms, while the concurrent Future.wait approach took only 53ms—a 48.09x faster speedup.

---

PR created automatically by Jules for task 10544993026701660389 started by @eng618

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Code Review

This pull request optimizes the loading of level labels in the settings screen by transitioning from sequential processing to concurrent processing using Future.wait. It also introduces a benchmark script to measure and compare the performance of both approaches. The review feedback suggests adopting Dart 3's indexed getter for cleaner iteration and using Stopwatch instead of DateTime.now() for more accurate benchmarking.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Using levels.asMap().entries to get the index and value is less idiomatic in Dart 3. We can use the indexed getter on Iterable combined with pattern destructuring. This is cleaner, more readable, and avoids allocating an intermediate Map object.

    final futures = levels.indexed.map((entry) async {
      final (index, lvl) = entry;
      try {
        final levelData = await ref.read(levelDataProvider(lvl).future);
        final difficulty = levelData.difficulty;
        return MapEntry(lvl, 'Level ${index + 1} ($lvl) — $difficulty');
      } catch (_) {
        return MapEntry(lvl, lvl);
      }
    });

[gemini-code-assist]

Similarly to the settings screen, we can use Dart 3's indexed getter on Iterable to simplify the code and avoid intermediate map allocation.

  final futures = levels.indexed.map((entry) async {
    final (index, lvl) = entry;
    try {
      final levelData = await fetchLevelData(lvl);
      final difficulty = levelData.difficulty;
      return MapEntry(lvl, 'Level ${index + 1} ($lvl) — $difficulty');
    } catch (_) {
      return MapEntry(lvl, lvl);
    }
  });

[gemini-code-assist]

Using DateTime.now() for benchmarking is less precise and can be affected by system clock adjustments. Using Stopwatch is the standard and more precise way to measure elapsed time in Dart. Additionally, using string interpolation instead of string concatenation is preferred per the Dart style guide.

Suggested change

	print('Running sequential...');
	final seqStart = DateTime.now();
	await loadLabelsSequential(levels);
	final seqEnd = DateTime.now();
	final seqDuration = seqEnd.difference(seqStart);
	print('Sequential time: ' + seqDuration.inMilliseconds.toString() + ' ms');
	print('Running concurrent...');
	final concStart = DateTime.now();
	await loadLabelsConcurrent(levels);
	final concEnd = DateTime.now();
	final concDuration = concEnd.difference(concStart);
	print('Concurrent time: ' + concDuration.inMilliseconds.toString() + ' ms');
	print('Improvement: ' + (seqDuration.inMilliseconds / concDuration.inMilliseconds).toStringAsFixed(2) + 'x faster');
	print('Running sequential...');
	final seqStopwatch = Stopwatch()..start();
	await loadLabelsSequential(levels);
	final seqMs = seqStopwatch.elapsedMilliseconds;
	print('Sequential time: $seqMs ms');
	print('Running concurrent...');
	final concStopwatch = Stopwatch()..start();
	await loadLabelsConcurrent(levels);
	final concMs = concStopwatch.elapsedMilliseconds;
	print('Concurrent time: $concMs ms');
	print('Improvement: ${(seqMs / concMs).toStringAsFixed(2)}x faster');

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric	Results
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[github-actions]

🚀 Preview Deployed!

Your changes are now live for testing:

🌐 Preview URL:

This preview will be automatically cleaned up when the PR is closed.