Repository navigation
Conversation
The Proxmox API returns the realm type as "realm-type" but PVEUser only read "realm_type", so the column was always empty in user list and in the report.
Since PVE 9.1, cluster/ha/rules also returns resource-affinity rules, which have no nodes key. The ha_groups check raised a KeyError on them and aborted the whole sanitycheck run.
…tings The fallback to the global node and vm settings tested the value for truthiness, so a per-cluster memoryminimum: 0 (documented in the README) was silently replaced by the global value.
$(command) substitution returned bytes. proxmoxer builds the API token header with str.format, which produced PVEAPIToken=b'user'!b'name'=b'value' and broke token authentication. The proxy_certificate JSON is now parsed from the str output.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four independent bug fixes, one commit each, each with a test that fails without the fix.
realm-type, the model readrealm_type, so the column was always empty inuser listand in the report. The report test now asserts the value, not just the key.cluster/ha/rulesalso returnsresource-affinityrules, which have nonodeskey. The check raisedKeyError: 'nodes'and aborted the wholesanitycheck. Adds afake_ha_resource_affinity_rulefixture and tests for the check.memoryminimum: 0(documented in the README) was replaced by the global value. Now onlyNone/ missing keys fall back.$(command)returnedbytes. proxmoxer 2.3.0 builds the token header withstr.format, producingPVEAPIToken=b'root@pam'!b'ci'=b'abcd', so token auth with$(...)could not work.proxy_certificateJSON is now parsed from thestroutput. Adds tests forrun_auth_commands.Note: #83 also fixes the
realm-typemapping as part of the dataclass refactor; the two will conflict onmodels/user.py, trivially.