Skip to content

🐛 app: misc fixes - #1286

Merged
dieguezguille merged 2 commits into
mainfrom
fixes
Sep 3, 2026
Merged

🐛 app: misc fixes#1286
dieguezguille merged 2 commits into
mainfrom
fixes

Conversation

@dieguezguille

@dieguezguille dieguezguille commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Performance

    • Activity history now loads additional entries as you scroll, improving performance for long lists.
    • Activity rows and headers adapt more reliably to device text-size settings.
  • Updates

    • Clarified asset section labels, including “Assets backing your credit” and “Other assets.”
    • Added updated Spanish and Portuguese translations for the revised asset labels.
  • Privacy

    • Sensitive information remains masked when privacy settings require it.

@dieguezguille dieguezguille self-assigned this Sep 2, 2026
@dieguezguille dieguezguille added bug Something isn't working enhancement New feature or request labels Sep 2, 2026
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4ce1096

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 28cf47bf-197a-4250-a754-17734b22319d

📥 Commits

Reviewing files that changed from the base of the PR and between 37cef35 and 1bb2e9d.

📒 Files selected for processing (2)
  • src/i18n/es.json
  • src/i18n/pt.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The mobile app now paginates activity items, calculates font-scaled list layouts, conditionally queries sensitive-text settings, and uses revised asset section titles with Spanish and Portuguese translations.

Changes

Mobile display updates

Layer / File(s) Summary
Activity pagination and layout
src/components/activity/Activity.tsx, src/components/activity/ActivityItem.tsx
Activity renders 40-item pages with scaled row heights, sticky headers, getItemLayout, and incremental loading. ActivityItem accepts an optional height and uses the shared router.
Conditional sensitive text rendering
src/components/shared/Text.tsx
TextComponent queries sensitive settings only when sensitive is enabled. Hidden content renders as ***.
Asset titles and translations
src/components/home/*.tsx, src/i18n/es.json, src/i18n/pt.json, .changeset/*.md
Asset headings use “Assets backing your credit” and “Other assets”. Spanish and Portuguese translations and patch changesets were updated.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 4ce10

The updated asset label is translated in Spanish and Portuguese, with no current merge-blocking risk identified.

Sequence Diagram(s)

sequenceDiagram
  participant Activity
  participant FlatList
  participant ActivityItem
  Activity->>FlatList: provide paginated items and item layout
  FlatList->>Activity: call onEndReached
  Activity->>FlatList: increase page limit by 40
  FlatList->>ActivityItem: render item with calculated height
Loading
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title uses the vague phrase "misc fixes" and does not identify the main changes, which include activity-list pagination and updated asset section titles. Replace the title with a concise, specific summary, such as "Optimize activity list scrolling and update asset titles".
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37cef354be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/activity/Activity.tsx
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.40%. Comparing base (f4fc241) to head (4ce1096).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/components/activity/Activity.tsx 92.85% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   73.37%   73.40%   +0.02%     
==========================================
  Files         276      276              
  Lines       13445    13463      +18     
  Branches     4704     4710       +6     
==========================================
+ Hits         9865     9882      +17     
- Misses       3241     3242       +1     
  Partials      339      339              
Flag Coverage Δ
e2e 73.40% <93.61%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfmelendez
nfmelendez requested a review from mainqueg September 3, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants