Codedev

[nfmelendez]

Summary by CodeRabbit

• Bug Fixes
  • Withdrawals now continue to execute even if sending a push notification fails.
  • Withdrawal proposals are correctly completed and removed, while notification errors are captured for review.
• Reliability
  • Improved handling ensures successful transfers are not blocked by temporary notification delivery issues.

[changeset-bot]

🦋 Changeset detected

Latest commit: 05958c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Warning

Review limit reached

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: af1a9694-5ae8-49f0-8f39-1d6a0719c8fa

📥 Commits

Reviewing files that changed from the base of the PR and between f0aeb43 and 05958c1.

📒 Files selected for processing (1)

• .changeset/quiet-otters-listen.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 1a52caf4-4271-4cba-b5fc-e3677620e76c

📥 Commits

Reviewing files that changed from the base of the PR and between 4eaad34 and f0aeb43.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• server/package.json
• server/test/hooks/block.test.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The change updates @simplewebauthn/server and adds a test confirming that withdrawal execution continues when one push notification fails.

Changes

Withdrawal notification resilience

Layer / File(s)	Summary
Withdrawal processing after notification failure server/test/hooks/block.test.ts	Adds coverage for two withdrawals when the first push notification rejects. The test verifies successful execution, transfers, proposal removal, error capture, and both notifications.
WebAuthn server dependency update server/package.json	Updates @simplewebauthn/server from ^13.3.0 to ^13.3.3.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f0aeb

This updates the WebAuthn server dependency and adds coverage ensuring a failed push notification does not interrupt withdrawal processing. The change is ready to merge with no identified current-head risk.

Suggested reviewers: aguxez, mainqueg

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title "Codedev" is too vague to identify the dependency update or notification-failure test added by this pull request.	Replace the title with a concise description of the main change, such as "Handle notification failures during withdrawal execution".

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codedev

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch codedev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.40%. Comparing base (4eaad34) to head (05958c1).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         276      276           
  Lines       13463    13463           
  Branches     4710     4711    +1     
=======================================
  Hits         9883     9883           
  Misses       3241     3241           
  Partials      339      339           

Flag	Coverage Δ
e2e	73.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.