Skip to content

👌 fix quadratic complexity in fragments_join #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petricevich wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −7
Open

👌 fix quadratic complexity in fragments_join #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions markdown_it/rules_inline/fragments_join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,25 @@ def fragments_join(state: StateInline) -> None:
and curr + 1 < maximum
and state.tokens[curr + 1].type == "text"
):
# collapse two adjacent text nodes
state.tokens[curr + 1].content = (
state.tokens[curr].content + state.tokens[curr + 1].content
)
else:
if curr != last:
state.tokens[last] = state.tokens[curr]
# Collapse a run of adjacent text nodes in a single join, instead
# of pairwise `a + b` concatenation. The pairwise form is O(L*k)
# in the size of the run because each step rebuilds the growing
# prefix; "".join is O(L).
parts = [state.tokens[curr].content]
curr += 1
while curr < maximum and state.tokens[curr].type == "text":
parts.append(state.tokens[curr].content)
curr += 1
merged = state.tokens[curr - 1]
merged.content = "".join(parts)
merged.level = level
state.tokens[last] = merged
last += 1
continue

if curr != last:
state.tokens[last] = state.tokens[curr]
last += 1
curr += 1

if curr != last:
Expand Down
Loading