[eas-cli]: warn user on missing primary locale#3894
Open
luke-h1 wants to merge 1 commit into
Open
Conversation
Author
|
/changelog-entry chore warn user on missing primary locale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR warns the user if an app's metadata they're attempting to update/add is missing the primary locale (and/or if they have another non-primary locale in their config). Providing a non-primary locale while you are missing primary locale can cause some confusion as it will show up blank in the ASC's dashboard
How
Log a warning to let the user know they might want to fill out the primary locale and/or change the app's primary language
How did you build this feature or fix this bug and why?
config.getLocales()and check whether the user has provided an empty object for their primary locale and whether they are using any non-primary locales i.e.Test Plan
Unit tests - not sure if there is a more automated / interactive way of building the CLI and testing a version so I just went with unit tests for the time being! happy to add more test coverage if there's a better way though