[eas-cli] Add -p alias for --platform in simulator:start#3902
Open
brentvatne wants to merge 2 commits into
Open
[eas-cli] Add -p alias for --platform in simulator:start#3902brentvatne wants to merge 2 commits into
brentvatne wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
✅ Thank you for adding the changelog entry! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3902 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 935 935
Lines 40931 40931
Branches 8622 8622
=======================================
Hits 24158 24158
Misses 16677 16677
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
no idea why codemention is failing here |
sjchmiela
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas simulator:startrequired the full--platformflag, while most other EAS CLI commands (build,submit,update, etc.) accept-pas a shorthand. This adds the same shorthand for consistency.How
Added
char: 'p'to theplatformflag definition insimulator/start.ts, matching the convention used across the rest of the CLI.Test Plan
🤖 Generated with Claude Code