Skip to content

[eas-cli] Use simulator session dashboard URLs#3904

Open
sjchmiela wants to merge 1 commit into
mainfrom
stanley/device-run-session-url
Open

[eas-cli] Use simulator session dashboard URLs#3904
sjchmiela wants to merge 1 commit into
mainfrom
stanley/device-run-session-url

Conversation

@sjchmiela

@sjchmiela sjchmiela commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Why

The Expo dashboard route for device run sessions moved to the simulator sessions surface, so EAS CLI should send users to that page and use the simulator-session terminology in user-facing output.

How

  • Add a dashboard URL helper that points device run sessions at /simulator-sessions/{id}.
  • Update eas simulator:{start,get,list} output and JSON to expose deviceRunSessionUrl using the simulator sessions route.
  • Update user-facing simulator command copy from "device run session" to "simulator session".

Test Plan

CI should pass.

@sjchmiela sjchmiela changed the title Use simulator session dashboard URLs [eas-cli] Use simulator session dashboard URLs Jun 26, 2026
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Jun 26, 2026
@sjchmiela sjchmiela marked this pull request as ready for review June 26, 2026 12:20
@sjchmiela sjchmiela requested a review from szdziedzic June 26, 2026 12:20
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.05%. Comparing base (efc78f4) to head (b1faaec).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/simulator/start.ts 45.46% 6 Missing ⚠️
packages/eas-cli/src/commands/simulator/list.ts 66.67% 2 Missing ⚠️
packages/eas-cli/src/commands/simulator/get.ts 85.72% 1 Missing ⚠️
packages/eas-cli/src/commands/simulator/stop.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3904      +/-   ##
==========================================
- Coverage   59.05%   59.05%   -0.00%     
==========================================
  Files         935      935              
  Lines       40959    40953       -6     
  Branches     8630     8621       -9     
==========================================
- Hits        24185    24181       -4     
+ Misses      16678    16677       -1     
+ Partials       96       95       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela force-pushed the stanley/device-run-session-url branch from db3e31a to b1faaec Compare June 26, 2026 12:27
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants