fix(create): dedupe uikit/three in starter Vite scaffold - #50
Open
malewis5 wants to merge 1 commit into
Open
Conversation
Fresh create@iwsdk apps crash the welcome UIKitML panel when Vite embeds two @pmndrs/uikit graphs (app super-three vs @drawcall/uikitml's three). Dedupe three/uikit in the scaffold Vite config, force a single three resolution via npm/pnpm overrides, and declare @pmndrs/uikit* as direct deps so resolve.dedupe works under clean pnpm installs (e.g. Vercel). Co-authored-by: Cursor <cursoragent@cursor.com>
meta-cla
Bot
added
the
CLA Signed
|
@zjm-meta has imported this pull request. If you are a Meta employee, you can view this in D115459999. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create @iwsdkapps crash loading the welcome UIKitML panel because Vite embeds two@pmndrs/uikitgraphs (appsuper-three@0.181vs@drawcall/uikitml'sthree@0.185).three/@pmndrs/uikit*in the scaffold Vite config and force a singlethreeresolution via npm/pnpm overrides so Horizon kit components and HTMLdivcontainers share one Component class.@pmndrs/uikit,@pmndrs/uikit-horizon, and@pmndrs/uikit-lucideas direct dependencies so Viteresolve.dedupe/optimizeDeps.includecan resolve them from the app root under pnpm (transitive-only installs breakvite buildon clean CI/Vercel).Supersedes #49.
Test plan
pnpm create @iwsdk@latest(or local create from this branch) into a clean directorypnpm install && pnpm devOnly pmndrs/uikit components can be added as childrenrm -rf node_modules/.vite && pnpm installstill produces a single uikit peer graph (no boththree@0.185.1andsuper-three@0.181.0uikit builds in Vite deps)node_modules/@pmndrs),pnpm run buildsucceedsMade with Cursor