Skip to content

[INTT-48] Add git-cliff config and fast-forward workflow#17

Open
mzaniolo wants to merge 2 commits into
tlater/incrementalfrom
mzaniolo/git-cliff
Open

[INTT-48] Add git-cliff config and fast-forward workflow#17
mzaniolo wants to merge 2 commits into
tlater/incrementalfrom
mzaniolo/git-cliff

Conversation

@mzaniolo

@mzaniolo mzaniolo commented Jun 3, 2026

Copy link
Copy Markdown

No description provided.


permissions = {
contents = "write";
"pull-requests" = "write";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pull-requests" = "write";
pull-requests = "write";

Comment on lines +12 to +19
on = {
issueComment = {
types = [
"created"
"edited"
];
};
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on = {
issueComment = {
types = [
"created"
"edited"
];
};
};
on.issueComment.types = [
"created"
"edited"
];

uses = allowed-actions."sequoia-pgp/fast-forward".uses;
with_ = {
merge = true;
comment = "on-error";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
comment = "on-error";
# Only post comments about fast-forwarding if
# there is an error.
comment = "on-error";

Comment thread nix/general/git-cliff.nix
filegen.settings.files = [
{
type = "copy";
target = "./cliff.toml";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the cliff.toml in a subdirectory instead? E.g. .config/cliff.toml? Just in case; we could even sub out the official cliff binary with one that sets a config file location.


["sequoia-pgp/fast-forward"]
rev = "v1.0.0"
ref = "ea7628bedcb0b0b96e94383ada458d812fca4979"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you double check this ref is currently permitted?

Comment thread nix/general/git-cliff.nix
}
];
};
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add cliff to the devshell?

@tlater-famedly tlater-famedly changed the title Add git-cliff config and fast-forward workflow [INTT-5] Add git-cliff config and fast-forward workflow Jun 10, 2026
@tlater-famedly tlater-famedly changed the title [INTT-5] Add git-cliff config and fast-forward workflow [INTT-48] Add git-cliff config and fast-forward workflow Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants