Reject unsupported Conv1D dilation during conversion - #1521
Merged
JanFSchulte merged 2 commits intoAug 11, 2026
Merged
Conversation
JanFSchulte
added
please test
JanFSchulte
requested changes
Aug 10, 2026
JanFSchulte
added
please test
JanFSchulte
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The Keras converter currently ignores
dilation_rate, while the generated Conv1D implementation uses dilation 1. Conversion therefore succeeds but can produce hardware whose computation differs from the source model. Failing early prevents silent incorrect output until dilated Conv1D is implemented.Fixes #1508.
Test plan
python -m pytest -q test/pytest/test_keras_converter.pypython -m pre_commit run --files hls4ml/converters/keras/convolution.py test/pytest/test_keras_converter.pygit diff --check