Fix bundle install on macOS by adding darwin platforms to Gemfile.next.lock#356
Merged
Fix bundle install on macOS by adding darwin platforms to Gemfile.next.lock#356
Conversation
Bundle install on macOS (arm64) failed because Gemfile.next.lock only listed `ruby` and `x86_64-linux` platforms, forcing a source build of nokogiri which fails locally (missing nokogiri_gumbo.h). Add arm64-darwin-23/24 and x86_64-darwin-21/22 to Gemfile.next.lock (matching Gemfile.lock) and bring Gemfile.lock current with arm64-darwin-24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUNDLE_GEMFILE=Gemfile.next bundle installwas failing on macOS (arm64) becauseGemfile.next.lockonly listed therubyandx86_64-linuxplatforms. Bundler fell back to building nokogiri from source, which fails locally withfatal error: 'nokogiri_gumbo.h' file not found.arm64-darwin-23/24,x86_64-darwin-21/22) toGemfile.next.lockso the precompiled native gems are used, matching the platform set already present inGemfile.lock.arm64-darwin-24inGemfile.lock(previously uncommitted local diff).Test plan
bundle exec rubocop— 120 files, 0 offenses.BUNDLE_GEMFILE=Gemfile.next bundle exec rubocop— 120 files, 0 offenses.bundle install(current Rails) — succeeds.BUNDLE_GEMFILE=Gemfile.next bundle install— succeeds (176 gems).bundle exec rspecagainst current Rails — 204 examples, 0 failures.BUNDLE_GEMFILE=Gemfile.next bundle exec rspecagainst next Rails — 204 examples, 0 failures.