Draft
Conversation
Group together prism-related pieces of code inside a new `harmonica._forward/prisms` module, organized in a similar way as the one for `ellipsoids`.
Reimplement the forward modeling computation of the gravity fields of a prism layer through a custom Numba function that iterates directly over the 1D horizontal coordinates of the layer. Replace the old implementation that used to build the whole set of prism boundaries and call the `prism_gravity` function. This new implementation doesn't require to store all those prisms in memory, significantly lowering the memory requirements, especially for large problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implement the
gravitymethod of the prism layer: rewrite the forward modeling computation of the gravity fields of a prism layer through a custom Numba function that iterates directly over the 1D horizontal coordinates of the layer. Replace the old implementation that used to build the whole set of prism boundaries and call theprism_gravityfunction. This new implementation doesn't require to store all those prisms in memory, significantly lowering the memory requirements, especially for large problems. Remove obsolete private function and method inlayer.py. Also, reorganize prism forward modelling into a submodule: group together prism-related pieces of code inside a newharmonica._forward/prismsmodule, organized in a similar way as the one forellipsoids.Relevant issues/PRs:
This issue has been found by @aguspesce, who noticed a significant amount of memory being used while forward modeling a large prism layer.