Skip to content

chore(csv-import-export): scaffold the CSV import/export plugin package - #65

Merged
fbritoferreira merged 3 commits into
mainfrom
feat/csv-import-export
Oct 9, 2026
Merged

fbritoferreira merged 3 commits into
mainfrom
feat/csv-import-export

Conversation

@fbritoferreira

Copy link
Copy Markdown
Owner

Summary

First of four stacked PRs for a CSV import/export plugin. This one is the package scaffold only: no business logic.

packages/csv-import-export/
├── package.json          # private: true, ./strapi-admin + ./strapi-server exports
├── admin/                # tsconfigs from the @strapi/sdk-plugin 6.1.1 template, placeholder page
├── server/src/index.ts   # empty lifecycle + registries
├── scripts/smoke.mjs     # packs the tarball, loads the server build (CI runs it on Node 20)
├── eslint.config.mjs, vitest.config.mts
└── README.md, docs/index.md, LICENCE.md

This is the first package here with a React admin bundle, so it builds with strapi-plugin build instead of tsc.

The package is "private": true. release.yml publishes every non-private package whose version is not on npm yet, with or without a changeset, so merging an empty plugin would otherwise publish it. PR 4 removes the flag.

Stack: this PR → server → admin UI → demo, docs and release.

Evidence

  • Before: no package.
    After: pnpm lint && pnpm typecheck && pnpm test && pnpm build && pnpm package:check && pnpm docs:build all exit 0 at the root; strapi-plugin verify passes.
  • node scripts/smoke.mjs prints smoke ok: tarball has admin and server builds, server entry loads. With "files": ["README.md"] it fails with tarball is missing dist/admin/index.js, so it catches the packaging mistake that shipped admin-api 1.2.0 without its build.

Design, plans and verification record: fbritoferreira/documentation#36.

Merge Danger

Door: two-way

Blast Radius: none

Private package; nothing is published and no other package or the demo depends on it.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc72a58f-ba8d-4b5a-875f-fa71aeb8456d

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​types/​react-dom@​18.3.71001007588100
Addedreact-intl@​6.8.9991007598100
Added@​strapi/​sdk-plugin@​6.1.1971009592100

View full report

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Priority Alert  (click "▶" to expand/collapse) Action
Low priority
Deprecated by its maintainer: npm @types/parse-path

Reason: This is a stub types definition. parse-path provides its own type definitions, so you do not need this installed.

From: pnpm-lock.yaml → npm/@strapi/sdk-plugin@6.1.1 → npm/@types/parse-path@7.1.0

ℹ Read more on: This package | This alert | What is a deprecated package?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@types/parse-path@7.1.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn

View full report

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for Test Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 100% (🎯 100%) 1361 / 1361
🟢 Statements 100% (🎯 100%) 1600 / 1600
🟢 Functions 100% (🎯 100%) 299 / 299
🟢 Branches 100% (🎯 100%) 1360 / 1360
File CoverageNo changed files found.
Generated in workflow #111 for commit eb6732d by the Vitest Coverage Report Action

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-09 19:55 UTC

@fbritoferreira
fbritoferreira added this pull request to stack #69 October 9, 2026 19:50
@fbritoferreira
fbritoferreira merged commit c007154 into main Oct 9, 2026
14 checks passed
@fbritoferreira
fbritoferreira deleted the feat/csv-import-export branch October 9, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant