Add ESP32-S2 and ESP32-S3 support - #856
Open
joelsernamoreno wants to merge 2 commits into
Open
Conversation
Contributor
|
Ever thought of just using UHS3? if not, why not? Technically UHS2 is targeted at weaker MCUs that typically don't have USB. UHS3 is designed so it won't collide with board supported USB, or other libraries. The only thing you would need to do is get it to cooperate with the S3, which is to make the RAM access in an ISR safe. This PR would break a lot of software that people have written over the years too, due to the way a lot of people interface with this library. |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds explicit support for ESP32-S2 and ESP32-S3 variants, which were previously not detected correctly because they do not define the ESP32 macro used by the generic ESP32 block.
Changes:
Note on SPI initialization:
Unlike the standard ESP32, the ESP32-S2 and ESP32-S3 require explicit SPI bus initialization in the sketch before calling Usb.Init(). Without this, the SPI bus will not be configured correctly and the USB host controller will fail to initialize:
SPI.begin(12, 13, 11, 10); // SCK, MISO, MOSI, SSThis has been tested and confirmed working on ESP32-S2.