Skip to content

Constant easing, fix keyframe holes, respect keyframe node.Weights, fix binary search, use vector.lerp/math.lerp - #12

Merged
ffrostfall merged 7 commits into
ffrostfall:mainfrom
Stenimated:fixes
Nov 8, 2025
Merged

ffrostfall merged 7 commits into
ffrostfall:mainfrom
Stenimated:fixes

Conversation

@Stenimated

@Stenimated Stenimated commented Nov 4, 2025 •

Copy link
Copy Markdown
Contributor

sorry for the big pr, changes accumulated after time and I forgot to split them up.
I probably forgot to write down every piece of fix, I had this branch lying around for a month

changes

  • added constant easing
  • handle animations that has keyframe holes, ex animations that may have missing keyframes throughout animations
  • expose limb_transforms , limb_name_to_index and limbs to make it easier to interact with roblox constraints [motor6d, animationconstraints]
  • updated tests, to include a motor6d comparision and a roblox animator comparison
  • fix keyframenode.Weight == 0, they shouldn't be animated
  • fixed binary search to not skip first keyframe and last keyframe
  • use math.lerp and vector.lerp

test changes
red is roblox
green is motor6d constraints
bottom is cframe sets
https://github.com/user-attachments/assets/9c64c426-145b-4d3d-b3a2-3aaac978a7c7

here a before I found, [1 month old clip I found]
https://github.com/user-attachments/assets/988f9c75-c09c-4a6a-ba0a-867888eee99b

keyframe hulls], FIX[selection between left and right for interpolation
for the binary search], EDIT[exported rig.limbs and rig.limb_transforms]
to make it easier to use Motor6D or AnimationConstraints, updated tests
to include a motor6d comparision and a roblox animator comparison
@Stenimated Stenimated changed the title Constant easing, fix animation hulls, respect keyframe node.Weights, fix binary search, use vector.lerp/math.lerp Constant easing, fix keyframe hules, respect keyframe node.Weights, fix binary search, use vector.lerp/math.lerp Nov 5, 2025
@Stenimated Stenimated changed the title Constant easing, fix keyframe hules, respect keyframe node.Weights, fix binary search, use vector.lerp/math.lerp Constant easing, fix keyframe holes, respect keyframe node.Weights, fix binary search, use vector.lerp/math.lerp Nov 5, 2025
Comment thread src/roblox/animation_asset.luau Outdated
@ffrostfall
ffrostfall merged commit c9b0fd1 into ffrostfall:main Nov 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants