Migrate /lp/es/contacto to design tokens + shared form primitives - #99
Merged
filipagr merged 1 commit intoJul 30, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
filipagr
force-pushed
the
filipa/fil-851-migrate-lp-es-contacto-to-design-tokens
branch
from
July 30, 2026 18:32
6830590 to
4bec5dd
Compare
filipagr
force-pushed
the
filipa/fil-851-migrate-lp-es-contacto-to-design-tokens
branch
from
July 30, 2026 18:34
4bec5dd to
25c665e
Compare
gmoranxyz
approved these changes
Jul 30, 2026
filecoinfoundation-inf
approved these changes
Jul 30, 2026
filecoinfoundation-inf
left a comment
filecoinfoundation-inf
left a comment
There was a problem hiding this comment.
Reviewed the diff — consistent form refactor onto shared FormControls with a backward-compatible localized network-error message addition. No security concerns.
filipagr
force-pushed
the
filipa/fil-851-migrate-lp-es-contacto-to-design-tokens
branch
from
July 30, 2026 21:43
25c665e to
4be3456
Compare
filipagr
force-pushed
the
filipa/fil-851-migrate-lp-es-contacto-to-design-tokens
branch
from
July 30, 2026 21:44
4be3456 to
29a576a
Compare
filipagr
force-pushed
the
filipa/fil-851-migrate-lp-es-contacto-to-design-tokens
branch
from
July 30, 2026 21:45
29a576a to
d0e7e0b
Compare
filipagr
force-pushed
the
filipa/fil-851-migrate-lp-es-contacto-to-design-tokens
branch
from
July 30, 2026 21:47
d0e7e0b to
8a895fe
Compare
Base automatically changed from
filipa/fil-850-migrate-waitlist-ai-agent-toolkit-to-design-tokens
to
main
July 30, 2026 21:48
Sixth page in the form/contact bucket (FIL-693); stacked on FIL-850. Spanish
contact form — the ES mirror of /contact-sales. Tokenizes the page
(57 → 0 inline/hex/font-string); zero raw form elements.
- ContactSalesBcnES.tsx: rebuilt on TextField / RadioField / Checkbox /
SubmitButton / FormSuccess / FormError + SectionLabel. i18n kept intact —
useLang("es"), PlatformNavbar/Footer lang="es" + ES hrefs, all ES copy,
and the "Barcelona ES Contacto" HubSpot context. data-hs-do-not-collect
preserved.
- hubspot.ts: submitHubSpotForm gains an optional `networkErrorMessage` so
localized pages surface a translated network-failure message instead of the
English default (this page passes the Spanish string). Backward-compatible.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
filipagr
force-pushed
the
filipa/fil-851-migrate-lp-es-contacto-to-design-tokens
branch
from
July 30, 2026 21:48
8a895fe to
0170017
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixth page in the form/contact bucket (FIL-851 / FIL-693). Spanish contact form — the ES mirror of
/contact-sales(~57 → 0 inline/hex/font-string). Zero raw form elements.What changed
src/pages/ContactSalesBcnES.tsx— rebuilt onTextField/RadioField/Checkbox/SubmitButton/FormSuccess/FormError+SectionLabel.useLang("es"),PlatformNavbar/Footerlang="es"+ ES hrefs (/lp/es/soporte,/lp/es/contacto), all Spanish copy, and the"Barcelona ES Contacto"HubSpot context.data-hs-do-not-collectpreserved.src/lib/hubspot.ts—submitHubSpotFormgains an optionalnetworkErrorMessageso localized pages show a translated network-failure message instead of the English default. This page passes the Spanish string. Backward-compatible (English pages unchanged).Verification
html lang="es", ES navbar/footer, all ES copy, the radio group, consent checkbox, and "Enviar" submit confirmed; no console errors.🤖 Generated with Claude Code