Repository navigation
Join geo on its own source_relation in the country and region reports - #67
Merged
fivetran-catfritz merged 1 commit intoOct 19, 2026
Conversation
fivetran-catfritz
changed the base branch from
main
to
MagicBot/fix-geo-source-relation-join
October 19, 2026 19:52
fivetran-catfritz
changed the base branch from
MagicBot/fix-geo-source-relation-join
to
bugfix/geo-source-relation-join
October 19, 2026 19:59
6 of 9 tasks
fivetran-avinash
approved these changes
Oct 19, 2026
fivetran-avinash
left a comment
fivetran-avinash
left a comment
Contributor
There was a problem hiding this comment.
@fivetran-catfritz lgtm!
fivetran-catfritz
added a commit
that referenced
this pull request
Oct 19, 2026
#68) * Join geo on its own source_relation in the country and region reports (#67) * Bump to v1.3.2, add geo integrity test, fix country seed geo IDs - Bump package version to 1.3.2 and add CHANGELOG entry for the geo join fix. - Add vertical_sum_monthly_geo_reports_by_source integrity test that compares staging and end model totals per source_relation. - Update country seed member_country values to match the geo seed so the country report join is exercised. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Delete integration_tests/tests/integrity/vertical_sum_monthly_geo_reports_by_source.sql * Simplify v1.3.2 CHANGELOG entry to focus on impact Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Remove deleted integrity test from CHANGELOG Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Generate dbt docs via GitHub Actions * Update CHANGELOG.md --------- Co-authored-by: Bishop Kammeraad <113325736+porkedchop@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: fivetran-data-model-bot <fivetran-data-model-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #66
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
Fixes the geo join in
linkedin_ads__monthly_campaign_country_reportandlinkedin_ads__monthly_campaign_region_reportto comparegeo.source_relationwithreport.source_relationinstead ofreport.source_relationwith itself.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB. Unioned two schemas of the integration test data: region report cost per source_relation goes from 3534.0 to 1767.0, matching the staging report.
dbt buildpasses on the package seeds.