Add feature instance to feature_operation instrumentation payload#998
Merged
Conversation
Subscribers can now access the Feature directly via payload[:feature] instead of having to look it up by name through a Flipper DSL instance. This is useful for snapshotting feature state at the point of operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payload[:feature]to thefeature_operation.flipperinstrumentation payload so subscribers can access the Feature instance (and its adapter) directly instead of looking it up by name.enable(:search)on a Flipper DSL, and asserts both the feature and its adapter are present on the payload.Test plan
bundle exec rspec spec/flipper/feature_spec.rb