Retire motion_mp(), which never worked - #375
Merged
Merged
Conversation
ARJ's call, after #370 established what it does. It rendered a motion video across several processes, coordinating them with a socket server and an argparse child, and it raised on its first call: two fields were read as one between the parent and the workers, and behind that failure it called `save_txt` and `save_analysis` with arguments in the wrong positions. So it produced nothing for anyone who tried it, and nothing tested it. The method stays as a stub that says all of that and points at `motion()`, which does the same work in one process and is tested. Someone whose script calls the old name gets a sentence rather than an AttributeError. The two modules behind it are deleted --- keeping a socket server and a child-process protocol that never worked serves nobody, and git remembers. The usual deprecate-now-remove-at-2.0 path is deliberately not used here. That convention protects working code, and there was none: nothing can have depended on a method that raises on its first call. Docs follow: both generated API pages removed, and the four references in MODULES.md, the module index, the results guide and the video-analysis guide. No dangling links remain. This also sets the floor #350 had reached. mypy goes from 26 errors to 17, which is exactly the count that was addressable without it, because typing code that cannot run would have been effort spent hiding a breakage. 682 tests pass, 4 skipped. Closes #370. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370. mypy 26 → 17, 682 tests pass.
motion_mp()rendered a motion video across several processes, coordinating them with a socket server and an argparse child. It raised on its first call — two fields were read as one between parent and workers — and behind that failure it calledsave_txtandsave_analysiswith arguments in the wrong positions. It produced nothing for anyone who tried it, and nothing tested it.motion(), which does the same work in one process and is tested. A script calling the old name gets a sentence, not anAttributeError.MODULES.md, the module index, the results guide and the video-analysis guide. No dangling links.The usual deprecate-now-remove-at-2.0 path is deliberately not used. That convention protects working code, and there was none — nothing can have depended on a method that raises on its first call.
This also sets the floor #350 had reached: 17 is exactly the count that was addressable without touching this, because typing code that cannot run would have been effort spent hiding a breakage.
🤖 Generated with Claude Code