Conversation
Closes #350. `mypy musicalgestures/` is clean across all 69 source files, from 248 when that issue was opened, and the `|| true` that made the step advisory is gone. No allowlist was needed in the end. The last eight were of a piece with the rest. `get_acceleration` declared `fps: int`, the same mistake `frame2ms` carried --- a frame rate is not an integer. Two GPU objects are created under a flag and used under the same flag, which mypy will not correlate. Three output names are resolved in one branch and read in another. And `_pose_mediapipe` and `_rerender_pose_from_cache` had no return annotation at all, so everything that returned their result returned Any. The version pin added in 3504a15 is what makes this safe to gate on. The count mypy reports moves with the checker as well as with the code: on identical source, 1.20.1 reports 169 errors where 2.3.1 reports 90. Blocking on an unpinned checker would let a release turn CI red with no change to the code. 682 tests pass, 4 skipped, on the same tree as the clean type check --- rerun after the motion_mp merge rather than carried over from before it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350.
mypy musicalgestures/is clean across all 69 source files, from 248 when that issue was opened, and the|| truethat made the step advisory is gone. No allowlist was needed in the end.The last eight
Of a piece with the rest of the backlog:
get_accelerationdeclaredfps: int— the same mistakeframe2mscarried. A frame rate is not an integer; 29.97 and 23.976 are ordinary._pose_mediapipeand_rerender_pose_from_cachehad no return annotation at all, so everything returning their result returnedAny.Why this is safe to gate on
The pin added in
3504a15is the precondition. The count mypy reports moves with the checker as well as with the code: on identical source, 1.20.1 reports 169 errors where 2.3.1 reports 90. Blocking on an unpinned checker would let a release turn CI red with no change to the code at all.Verification
682 tests pass, 4 skipped, on the same tree as the clean type check — rerun after the
motion_mpmerge rather than carried over from before it.🤖 Generated with Claude Code