feat: handle old and new Babel configs#1789
Open
ojeytonwilliams wants to merge 3 commits intofreeCodeCamp:mainfrom
Open
feat: handle old and new Babel configs#1789ojeytonwilliams wants to merge 3 commits intofreeCodeCamp:mainfrom
ojeytonwilliams wants to merge 3 commits intofreeCodeCamp:mainfrom
Conversation
Nirajn2311
reviewed
May 8, 2026
| challenge!, | ||
| _babelWebView.webViewController, | ||
| ); | ||
| userCode = userCodeVariants.transpileScriptWithTargets; |
Member
There was a problem hiding this comment.
This only tests the challenges against one variant ie. the variant with targets, in the editor
Contributor
Author
There was a problem hiding this comment.
Thanks Niraj, I've updated it to use both.
I didn't entirely understand what was going on in the test code, so I refactored it a bit until I could make sense of it. I hope that's okay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of the repo.freeCodeCamp/freeCodeCamp#53127 changes a bunch of challenges to be compatible with the new Babel config, but unfortunately they're not compatible with the old config. This works around that by testing against both configs and passing the challenge if at least one test passes.
I tried to test this locally, but I can't seem to get the emulator working. Sorry about that.