Skip to content

ci(skillsaw): add lint job, Makefile targets, and repo config #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ralphbean wants to merge 6 commits into from
Open

ci(skillsaw): add lint job, Makefile targets, and repo config #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b95de9
ci(skillsaw): add lint job, Makefile targets, and repo config
ralphbean Aug 11, 2026
70451ce
fix(skillsaw): address review feedback on lint CI config
ralphbean Aug 13, 2026
b28508d
fix(skillsaw): correct uvx syntax and add lint.yml to workflows table
fullsend-ai-coder[bot] Aug 13, 2026
869fd2f
fix(skillsaw): use canonical claude- rule IDs, correct marketplace co…
ralphbean Aug 13, 2026
ec4ee8e
fix(skillsaw): use baseline ratchet instead of raised context-budget …
ralphbean Aug 13, 2026
e15628c
fix(skillsaw): regenerate baseline against PR's actual merge tree
ralphbean Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ permissions:
contents: read

jobs:
skillsaw:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Comment thread
qodo-code-review[bot] marked this conversation as resolved.
Comment thread
ralphbean marked this conversation as resolved.
with:
persist-credentials: false
Comment thread
ralphbean marked this conversation as resolved.
Comment thread
ralphbean marked this conversation as resolved.
Comment thread
ralphbean marked this conversation as resolved.
Comment thread
ralphbean marked this conversation as resolved.
Comment thread
ralphbean marked this conversation as resolved.

@fullsend-ai-review fullsend-ai-review Bot Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] consistency

The skillsaw job sets persist-credentials: false on its checkout step, while the test and commit-lint jobs in the same file omit this parameter. Since persist-credentials: false is a security hardening measure, the preferred resolution is to add it to the other two jobs in a follow-up PR rather than removing it here.

- uses: stbenjam/skillsaw@c325108b6cf94284762948b6a463e75ab5288520 # v0.18.0

@waynesun09 waynesun09 Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] Three independent skillsaw version pins can silently drift out of sync

The skillsaw version is recorded three separate times with nothing tying them together: this line pins the Action via stbenjam/skillsaw@c325108b6cf94284762948b6a463e75ab5288520 # v0.18.0, Makefile:8 sets SKILLSAW_VERSION := 0.18.0 (consumed by make lint/make lint-fix via uvx skillsaw@$(SKILLSAW_VERSION)), and .skillsaw.yaml:4 has version: "0.18.0". Renovate can bump the Action's SHA pin automatically but has no visibility into the Makefile variable or the YAML version string, so a future Action bump can leave local make lint runs on a different skillsaw release than CI.

Suggestion: Consolidate to one source of truth (e.g., have CI install via uvx skillsaw@$(SKILLSAW_VERSION) reusing the Makefile variable instead of the dedicated Action), or add a Renovate custom regex manager that also bumps SKILLSAW_VERSION in the Makefile and version: in .skillsaw.yaml whenever the Action pin moves.

with:
strict: true

test:
runs-on: ubuntu-24.04
steps:
Expand Down
52 changes: 52 additions & 0 deletions .skillsaw-baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
Comment thread
ralphbean marked this conversation as resolved.
"version": "1",
"generated_by": "skillsaw 0.18.0",
"generated_at": "2026-08-14T00:51:52.809910+00:00",
"violations": [
{
"fingerprint": "22073290a7e46a35",
"rule_id": "context-budget",
"file_path": "skills/retro-analysis/SKILL.md",
"message": "Estimated 3,434 tokens exceeds skill warn limit of 3,000",
"severity": "warning",
"value": 3434,
"baseline_mode": "ceiling"
},
{
"fingerprint": "0285e1a7243ebead",
"rule_id": "context-budget",
"file_path": "skills/pr-review/SKILL.md",
"message": "Estimated 15,058 tokens exceeds skill error limit of 6,000",
"severity": "error",
"value": 15058,
"baseline_mode": "ceiling"
},
{
"fingerprint": "910d4f5f259c6510",
"rule_id": "context-budget",
"file_path": "skills/fix-review/SKILL.md",
"message": "Estimated 3,859 tokens exceeds skill warn limit of 3,000",
"severity": "warning",
"value": 3859,
"baseline_mode": "ceiling"
},
{
"fingerprint": "43a3bb24cb22288e",
"rule_id": "context-budget",
"file_path": "skills/code-review/SKILL.md",
"message": "Estimated 3,842 tokens exceeds skill warn limit of 3,000",
"severity": "warning",
"value": 3842,
"baseline_mode": "ceiling"
},
{
"fingerprint": "8aba1d160bb4c413",
"rule_id": "context-budget",
"file_path": "skills/code-implementation/SKILL.md",
"message": "Estimated 9,116 tokens exceeds skill error limit of 6,000",
"severity": "error",
"value": 9116,
"baseline_mode": "ceiling"
}
]
}
Loading
Loading