fix(#809): disambiguate scope clause in correctness sub-agent - #810
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#809): disambiguate scope clause in correctness sub-agent#810fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The correctness sub-agent was suppressing valid beyond-diff findings by reasoning they were "outside PR scope" — a dimensional filter it does not own. Two changes fix this: 1. Add a disambiguation paragraph after the "Do not own: PR scope" clause clarifying that the clause means "don't judge whether the PR's scope is appropriate" (intent-coherence's job), not "suppress correctness findings about files outside the diff." 2. Add "Cross-variant parity" as an explicit check pattern alongside consumer-completeness and removal/rename-staleness, directing the sub-agent to verify sibling variants remain consistent when the diff modifies one variant. Note: pre-commit could not run (sandbox network policy blocked git fetch during hook environment setup). Bundle check passed. Closes #809
|
🤖 Finished Review · ✅ Success · Started 7:28 PM UTC · Completed 7:38 PM UTC Commit: |
ReviewFindingsMedium
Labels: PR modifies a review sub-agent definition under skills/pr-review/sub-agents/ |
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
On PR #752, the correctness sub-agent identified that the GitLab variant of the
issue-labelsskill was missing a trigger phrase added to the GitHub variant, but suppressed the finding as "outside PR scope." A human reviewer had flagged the same gap. The sub-agent's "Do not own: PR scope" clause was being misinterpreted as license to suppress any finding about files not in the diff, when it should only mean the sub-agent should not judge whether the PR's scope is right or wrong.Testing
make check-bundlepasses (this change does not touch any bundled scripts)Closes #809
Post-script verification
agent/809-correctness-scope-disambiguation)693ed83bbd5289e1ef13d6c7a3772f61efc43c86..HEAD)