Skip to content

docs(#2653): add maintainer onboarding process - #6207

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/2653-maintainer-onboarding-doc
Open

docs(#2653): add maintainer onboarding process#6207
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/2653-maintainer-onboarding-doc

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Adds MAINTAINERS.md documenting the maintainer onboarding process and links it from CONTRIBUTING.md. This reworks the approach from the closed PR #2603, incorporating review feedback from maintainers.

Related Issue

Addresses #2653.

Changes

  • New MAINTAINERS.md at the repo root with sections covering:
    • What maintainers do that contributors do not (review/approval, triage, project health, standards)
    • Eligibility criteria (merged PRs or substantive reviews required)
    • Nomination process (file an issue, group consensus, one-week decision)
    • Time commitment (ongoing participation expected, no fixed hours)
    • Team meetings and communication (not automatically included, public channels planned)
    • Stepping down process
  • Updated CONTRIBUTING.md with a new "Maintainers" section linking to MAINTAINERS.md

Key improvements over the previous PR #2603:

  • Addresses the "no time commitment" concern by setting an expectation of ongoing participation
  • Distinguishes maintainer responsibilities from contributor rights
  • Acknowledges that private channels (Slack, meetings) are not included and that public coordination channels are not yet in place
  • Requires merged PRs as eligibility evidence (not just participation)
  • Specifies group consensus for approval decisions

Testing

  • make lint-md-links passes (no broken links)
  • Markdown renders correctly
  • Secret scan passed

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Documentation-only change — no code or test changes needed

Closes #2653

Post-script verification

  • Branch is not main/master (agent/2653-maintainer-onboarding-doc)
  • Secret scan passed (gitleaks — 730da3796162eddc495833904ea1b9ed35587b81..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

Add MAINTAINERS.md documenting how to become a maintainer, and
link it from CONTRIBUTING.md for discoverability.

This reworks the approach from the closed PR #2603, addressing
review feedback:

- Distinguishes maintainer responsibilities from contributor
  rights (PR review/approval, issue triage, project health)
- Sets an expectation of ongoing participation instead of
  claiming "no time commitment"
- Clarifies that team meetings and private channels are not
  automatically included with maintainer status
- Requires merged PRs or substantive reviews as eligibility
  evidence, not just participation
- Specifies that approval requires group consensus among
  existing maintainers
- Adds a section on stepping down gracefully

Note: pre-commit could not run (sandbox network policy blocks
git fetch for hook installation). Markdown link checker passed.

Closes #2653
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 13, 2026 20:09
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Aug 13, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 13, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:11 PM UTC · Completed 8:26 PM UTC

Commit: b2aac36 · View workflow run →

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [list-formatting-consistency] MAINTAINERS.md:31 — The Process section uses bold text for leading phrases in numbered list items (**File an issue**, **Current maintainers discuss.**, **Decision within one week.**), while the vouch process in CONTRIBUTING.md uses numbered lists without bold on the action phrases. The bold lead-in pattern is internally consistent within MAINTAINERS.md and improves scannability of the multi-paragraph process steps, so this is a minor style observation rather than a clear inconsistency.

Labels: PR adds and modifies documentation files (MAINTAINERS.md, CONTRIBUTING.md)

Comment thread MAINTAINERS.md
@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge component/docs User-facing documentation labels Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation ready-for-merge All reviewers approved — ready to merge ready-for-review Agent PR ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document and formalize maintainer onboarding process

2 participants