chore(#6228): add qodo pr-agent config to disable stale Go test rules - #6230
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
chore(#6228): add qodo pr-agent config to disable stale Go test rules#6230fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The qodo-code-review Go convention pack rules TC-001 and TC-002 mandate stdlib-only testing (no testify). This project uses testify/assert and testify/require in 72% of test files (156/216), so these rules produce false positives on idiomatic project test code. Add a .pr_agent.toml repo-level configuration file with extra_instructions telling qodo's reviewer and code-suggestions tools to skip TC-001/TC-002 enforcement and not suggest replacing testify with stdlib assertions. Closes #6228
|
🤖 Finished Review · ✅ Success · Started 4:07 PM UTC · Completed 4:18 PM UTC Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR adds tooling configuration for the qodo code review bot (CI pipeline component) |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
.pr_agent.tomlrepo-level configuration file to disable qodo-code-review convention pack rules TC-001 and TC-002, which mandate stdlib-only Go testing (no testify). The project usestestify/assertandtestify/requirein 72% of test files, making these rules a standing source of false-positive findings on Go test PRs.Related Issue
Closes #6228
Changes
.pr_agent.tomlwith[pr_reviewer]and[pr_code_suggestions]sectionsextra_instructionstelling qodo to skip TC-001/TC-002 enforcement and not suggest replacing testify with stdlib assertionsTesting
Checklist
!for breaking changes)Note: pre-commit could not run in the sandbox (network restriction on git fetch for hook environment setup). The post-script runs pre-commit authoritatively on the runner.
Closes #6228
Post-script verification
agent/6228-disable-stale-qodo-rules)b5314d3b59172d150587d159903642319b28d1d1..HEAD)