docs(#6231): require runtime discovery for agent/skill inventory refs - #6234
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#6231): require runtime discovery for agent/skill inventory refs#6234fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a rule to AGENTS.md requiring runtime discovery commands against fullsend-ai/agents when referencing the agent, skill, or sub-agent inventory. Hardcoded static tables go stale because the agents repo evolves independently. This rule prevents the rework pattern observed in PR #6202, where a code agent produced a hardcoded inventory that required a near-total rewrite. Points readers to the author-fullsend-augmentations skill for concrete discovery patterns. Note: pre-commit could not run in the sandbox due to network restrictions (git fetch blocked). The post-script runs pre-commit authoritatively on the runner. Closes #6231
|
🤖 Finished Review · ✅ Success · Started 4:55 PM UTC · Completed 5:07 PM UTC Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsMedium
Labels: PR modifies AGENTS.md, a documentation/governance file |
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a repo-level rule to AGENTS.md requiring runtime discovery commands (not hardcoded tables) when writing content that references the fullsend agent/skill/sub-agent inventory. This prevents the rework pattern observed in PR #6202, where a code agent synthesized a static inventory from training data that went stale immediately.
Changes
AGENTS.md, placed after the existing documentation rulesfullsend-ai/agentsand references theauthor-fullsend-augmentationsskill for concrete patternsTesting
gitlint --commit HEADpassesCloses #6231
Post-script verification
agent/6231-discovery-over-hardcoded)4bfc8988be00438547d53e2d4ab1fa4211563eaa..HEAD)