GTFS追加 - #22
Open
hikaru-0602 wants to merge 16 commits into
Open
Conversation
Co-authored-by: Kanta Oikawa <oikawa_kanta@cyberagent.co.jp>
Co-authored-by: Kanta Oikawa <oikawa_kanta@cyberagent.co.jp>
Co-authored-by: Kanta Oikawa <oikawa_kanta@cyberagent.co.jp>
Co-authored-by: Kanta Oikawa <oikawa_kanta@cyberagent.co.jp>
…date_bus.tf Co-authored-by: Kanta Oikawa <oikawa_kanta@cyberagent.co.jp>
…date_bus.tf Co-authored-by: Kanta Oikawa <oikawa_kanta@cyberagent.co.jp>
hikaru-0602
requested review from
a team,
Hosoda-abo,
kantacky and
masaya-osuga
August 6, 2026 15:51
kantacky
reviewed
Aug 10, 2026
kantacky
left a comment
kantacky
left a comment
Member
There was a problem hiding this comment.
SecretManager側でサービスアカウントにシークレットアクセサーロールを付与しないとかも？
あと、Cloud SQLのdotto_serviceロールをサービスアカウントに付与しないとかも
| } | ||
|
|
||
| variable "schedule" { | ||
| default = "0 6 * * *" |
Member
There was a problem hiding this comment.
朝の3時でも良さそう
始発って6時くらいだっけ
Suggested change
| default = "0 6 * * *" | |
| default = "0 3 * * *" |
| service_account_display_name = "Import GTFS Job (Dev)" | ||
| db_name = "dotto_dev" | ||
| service_name = "import-gtfs-job-dev" | ||
| schedule = "0 4 * * *" |
Member
There was a problem hiding this comment.
devで前の日の夜にやってエラー出たら次の朝までに対応できそう
Suggested change
| schedule = "0 4 * * *" | |
| schedule = "0 21 * * *" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと