科目詳細ページを実装 - #25
Open
T-shinku0314 wants to merge 5 commits into
Open
Conversation
Contributor
Author
詳細画面のスクショです。
|
| params: { path: { id } }, | ||
| }); | ||
|
|
||
| if (error || !data) { |
Member
There was a problem hiding this comment.
今回は難しいかもだから直さなくてもいいけど、エラーハンドリングを適切にできると良さそう
404の時はNot Found的な感じかな
https://developer.mozilla.org/ja/docs/Web/HTTP/Reference/Status
↑とかみてみると面白いかも
サーバー側もやってみて、ここら辺の理解を深めよう
Member
There was a problem hiding this comment.
Deploying dotto-web-storybook with
|
| Latest commit: |
77f607b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7567f9e.dotto-web-storybook.pages.dev |
| Branch Preview URL: | https://feature-subjects-detail.dotto-web-storybook.pages.dev |
kantacky
approved these changes
Jul 28, 2026
Member
There was a problem hiding this comment.
@masaya-osuga のコメントだけ修正できれば良さそう！
あと、戻るボタンって結局必要なんだっけ？
このブランチにmainをマージしたので、修正前にこのブランチを一回pullしてもらえると！
Contributor
Author
|
レビューありがとうございます！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと