P-2379 Correct CLI filter examples - #28
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae3363c04c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| orderDir?: string | ||
| expand?: string | ||
| conditions?: string | ||
| filters?: string |
There was a problem hiding this comment.
Existing scripts using the previously documented profiles search --conditions ... option no longer supply any filter after this schema key is renamed to filters; depending on incur's unknown-option handling, they either fail immediately or perform an unfiltered search. Keep conditions as a deprecated alias that is normalized to the new canonical filters request field so upgrading the CLI does not break or broaden existing searches.
Useful? React with 👍 / 👎.
| filters: z | ||
| .string() | ||
| .describe('JSON array of filter set strings defining the segment'), | ||
| .describe( | ||
| 'JSON array of canonical {"field","op","value"} filter objects', |
There was a problem hiding this comment.
The required segment-create option was previously exposed and documented as --filter-sets; replacing it outright with --filters causes every existing formo segments create script to fail validation before making its request. Accept the legacy option as a deprecated alias and translate its DSL values, or provide an explicit migration path rather than removing the published flag in place.
Useful? React with 👍 / 👎.
1 participant
Summary
field::op::valueDSL--filter-setsas the segment create-requestfilterSetsinputpage_scopethrough analytics--paramsValidation
Live integration tests remain skipped because no valid
TEST_TOKENis configured.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.