Skip to content

Fix empty commit links in CLI release notes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosriady merged 2 commits into from
Aug 3, 2026
Merged

Fix empty commit links in CLI release notes #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d14f6a2
fix release note commit links
yosriady Aug 3, 2026
9e0398b
harden release note commit parsing
yosriady Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,17 +110,24 @@ jobs:
RELEASE_DATE=$(date +%Y-%m-%d)

if [ -n "$PREV_TAG" ]; then
COMMITS=$(git log ${PREV_TAG}..HEAD --pretty=format:"%s %h" --no-merges)
# Put the hash first and separate it from the subject with a real
# tab. The loop below validates the hash before making a link, so
# malformed log output cannot silently publish an empty URL.
COMMITS=$(git log "${PREV_TAG}..HEAD" --pretty=format:'%h%x09%s' --no-merges)
else
COMMITS=$(git log --pretty=format:"%s %h" --no-merges)
COMMITS=$(git log --pretty=format:'%h%x09%s' --no-merges)
fi

FEATURES=""
FIXES=""
OTHER=""

while IFS=$'\t' read -r message hash; do
while IFS=$'\t' read -r hash message; do
[ -z "$message" ] && continue
if [[ ! $hash =~ ^[0-9a-f]+$ ]]; then
echo "❌ Could not parse commit hash for release-note entry: $message" >&2
exit 1
fi
if [[ $message =~ \(#([0-9]+)\) ]]; then
PR_NUM="${BASH_REMATCH[1]}"
CLEAN_MESSAGE=$(echo "$message" | sed -E 's/ ?\(#[0-9]+\)//')
Expand Down