Skip to content

remove name from tun options to avoid possible conflicts - #584

Merged
garmr-ulfr merged 1 commit into
mainfrom
remove-fixed-tun-name
Jul 29, 2026
Merged

remove name from tun options to avoid possible conflicts#584
garmr-ulfr merged 1 commit into
mainfrom
remove-fixed-tun-name

Conversation

@garmr-ulfr

@garmr-ulfr garmr-ulfr commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

This pull request makes a small change to the vpn/boxoptions_default.go file by removing the explicit setting of the InterfaceName field in the TunInboundOptions struct. This allows the OS to assign one, avoiding possible conflicts.

closes getlantern/engineering/issues/3707.

Copilot AI review requested due to automatic review settings July 29, 2026 18:38
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@garmr-ulfr, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 56d2c0e1-3a8e-442e-b711-8a42271a36d7

📥 Commits

Reviewing files that changed from the base of the PR and between 149f0d7 and 6bacf68.

📒 Files selected for processing (1)
  • vpn/boxoptions_default.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the hard-coded TUN interface name from the default sing-box TunInboundOptions so the OS can assign an available interface name and avoid potential naming conflicts.

Changes:

  • Removed explicit InterfaceName assignment ("utun225") from the default TUN inbound options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@garmr-ulfr

Copy link
Copy Markdown
Collaborator Author

Bringing this in, we don't have any reason/need to fix the TUN name.

@garmr-ulfr
garmr-ulfr merged commit ce32d92 into main Jul 29, 2026
4 checks passed
@garmr-ulfr
garmr-ulfr deleted the remove-fixed-tun-name branch July 29, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants